Page MenuHomeWildfire Games

Increase outpost base vision to 10
ClosedPublic

Authored by wraitii on Jan 24 2021, 9:33 AM.

Details

Reviewers
None
Commits
rP24779: Increase outpost base vision to 10
Trac Tickets
#5974
Summary

Outposts have a vision range of 4. Until D3054 is committed, this makes them sometimes not give any actual vision, which looks bugg
y.
Also clarify that they need to be garrisoned in the tooltip.

Test Plan

Agree

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

wraitii created this revision.Jan 24 2021, 9:33 AM
Owners added a subscriber: Restricted Owners Package.Jan 24 2021, 9:34 AM

Build is green

builderr-debug-macos.txt
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framework/CoreVideo.tbd and library file /System/Library/Frameworks//CoreVideo.framework/CoreVideo are out of sync. Falling back to library file for linking.
ld: warning: text-based stu

See https://jenkins.wildfiregames.com/job/macos-differential/3034/display/redirect for more details.

wraitii requested review of this revision.Jan 24 2021, 9:49 AM

Why 10 instead of 8?

binaries/data/mods/public/simulation/templates/template_structure_defensive_outpost.xml
38 ↗(On Diff #15657)

No vision range on its own.? It's basically none.

Why 10 instead of 8?

No reason except round numbers look better IMO :p

wraitii added inline comments.Jan 24 2021, 11:54 AM
binaries/data/mods/public/simulation/templates/template_structure_defensive_outpost.xml
38 ↗(On Diff #15657)

Going to go with No vision range unless garrisoned.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 24 2021, 12:05 PM
This revision was automatically updated to reflect the committed changes.