Page MenuHomeWildfire Games
Differential D3467

Limit possibility of brute force attacks when guessing password
ClosedPublic
Actions

Authored by Silier on Jan 24 2021, 8:06 PM.

Details

Reviewers
None
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP24794: Limit possibility of brute force attacks when guessing password
Summary

This is supposed to prevent attackers from getting connection data by guessing the password.

Each failed attempt increases the counter.
XmppClient on the server side checks for the users with 3 failed attempts and blocks them even before checking the password.

Test Plan

host match with password
try to connect entering wrong password 4 times

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Silier created this revision.Jan 24 2021, 8:06 PM
Owners added a subscriber: Restricted Owners Package.Jan 24 2021, 8:06 PM
Silier published this revision for review.Jan 24 2021, 8:06 PM
Silier edited the summary of this revision. (Show Details)
Vulcan added a comment.Jan 24 2021, 8:13 PM

Build is green

builderr-debug-macos.txt
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libnetwork_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/liblobby_dbg.a(precompiled.o) has no symbols
../../../source/network/scripting/JSInterface_Network.cpp:171:71: warning: unused parameter 'pCmptPrivate' [-Wunused-parameter]
void JSI_Network::StartNetworkJoinLobby(ScriptInterface::CmptPrivate* pCmptPrivate, const CStrW& playerName, const CStr& hostJID, const CStr& password)
                                                                      ^
1 warning generated.
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libengine_dbg.a(precompiled.o) has no symbols
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/Core

See https://jenkins.wildfiregames.com/job/macos-differential/3041/display/redirect for more details.

Vulcan added a comment.Jan 24 2021, 8:19 PM

Build is green

builderr-debug-gcc7.txt
../../../source/network/scripting/JSInterface_Network.cpp: In function 'void JSI_Network::StartNetworkJoinLobby(ScriptInterface::CmptPrivate*, const CStrW&, const CStr8&, const CStr8&)':
../../../source/network/scripting/JSInterface_Network.cpp:171:71: warning: unused parameter 'pCmptPrivate' [-Wunused-parameter]
 void JSI_Network::StartNetworkJoinLobby(ScriptInterface::CmptPrivate* pCmptPrivate, const CStrW& playerName, const CStr& hostJID, const CStr& password)
                                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~
builderr-release-gcc7.txt
../../../source/network/scripting/JSInterface_Network.cpp: In function 'void JSI_Network::StartNetworkJoinLobby(ScriptInterface::CmptPrivate*, const CStrW&, const CStr8&, const CStr8&)':
../../../source/network/scripting/JSInterface_Network.cpp:171:71: warning: unused parameter 'pCmptPrivate' [-Wunused-parameter]
 void JSI_Network::StartNetworkJoinLobby(ScriptInterface::CmptPrivate* pCmptPrivate

See https://jenkins.wildfiregames.com/job/docker-differential/4699/display/redirect for more details.

Harbormaster completed remote builds in B15390: Diff 15668.Jan 24 2021, 8:20 PM
Silier updated this revision to Diff 15669.Jan 24 2021, 8:21 PM

restore counter after correct password so user can misstype when rejoining

Vulcan added a comment.Jan 24 2021, 8:29 PM

Build is green

builderr-debug-macos.txt
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libnetwork_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/liblobby_dbg.a(precompiled.o) has no symbols
../../../source/network/scripting/JSInterface_Network.cpp:171:71: warning: unused parameter 'pCmptPrivate' [-Wunused-parameter]
void JSI_Network::StartNetworkJoinLobby(ScriptInterface::CmptPrivate* pCmptPrivate, const CStrW& playerName, const CStr& hostJID, const CStr& password)
                                                                      ^
1 warning generated.
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libengine_dbg.a(precompiled.o) has no symbols
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/Core

See https://jenkins.wildfiregames.com/job/macos-differential/3042/display/redirect for more details.

Vulcan added a comment.Jan 24 2021, 8:34 PM

Build is green

builderr-debug-gcc7.txt
../../../source/network/scripting/JSInterface_Network.cpp: In function 'void JSI_Network::StartNetworkJoinLobby(ScriptInterface::CmptPrivate*, const CStrW&, const CStr8&, const CStr8&)':
../../../source/network/scripting/JSInterface_Network.cpp:171:71: warning: unused parameter 'pCmptPrivate' [-Wunused-parameter]
 void JSI_Network::StartNetworkJoinLobby(ScriptInterface::CmptPrivate* pCmptPrivate, const CStrW& playerName, const CStr& hostJID, const CStr& password)
                                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~
builderr-release-gcc7.txt
../../../source/network/scripting/JSInterface_Network.cpp: In function 'void JSI_Network::StartNetworkJoinLobby(ScriptInterface::CmptPrivate*, const CStrW&, const CStr8&, const CStr8&)':
../../../source/network/scripting/JSInterface_Network.cpp:171:71: warning: unused parameter 'pCmptPrivate' [-Wunused-parameter]
 void JSI_Network::StartNetworkJoinLobby(ScriptInterface::CmptPrivate* pCmptPrivate

See https://jenkins.wildfiregames.com/job/docker-differential/4700/display/redirect for more details.

Harbormaster completed remote builds in B15391: Diff 15669.Jan 24 2021, 8:35 PM
Silier updated this revision to Diff 15670.Jan 24 2021, 8:38 PM

reuse string

wraitii added a subscriber: wraitii.Jan 24 2021, 8:41 PM
wraitii added inline comments.
binaries/data/mods/public/gui/gamesetup_mp/gamesetup_mp.js
168 ↗(On Diff #15670)

hm I mostly just suggested duplicating the string, which I believe will pick up the translation all the same. This looks more hacky.

Vulcan added a comment.Jan 24 2021, 8:51 PM

Build is green

builderr-debug-gcc7.txt
../../../source/network/scripting/JSInterface_Network.cpp: In function 'void JSI_Network::StartNetworkJoinLobby(ScriptInterface::CmptPrivate*, const CStrW&, const CStr8&, const CStr8&)':
../../../source/network/scripting/JSInterface_Network.cpp:171:71: warning: unused parameter 'pCmptPrivate' [-Wunused-parameter]
 void JSI_Network::StartNetworkJoinLobby(ScriptInterface::CmptPrivate* pCmptPrivate, const CStrW& playerName, const CStr& hostJID, const CStr& password)
                                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~
builderr-release-gcc7.txt
../../../source/network/scripting/JSInterface_Network.cpp: In function 'void JSI_Network::StartNetworkJoinLobby(ScriptInterface::CmptPrivate*, const CStrW&, const CStr8&, const CStr8&)':
../../../source/network/scripting/JSInterface_Network.cpp:171:71: warning: unused parameter 'pCmptPrivate' [-Wunused-parameter]
 void JSI_Network::StartNetworkJoinLobby(ScriptInterface::CmptPrivate* pCmptPrivate

See https://jenkins.wildfiregames.com/job/docker-differential/4701/display/redirect for more details.

Silier updated this revision to Diff 15672.Jan 24 2021, 9:06 PM

actually reuse already translated string

wraitii added inline comments.Jan 24 2021, 9:13 PM
source/network/NetServer.cpp
1643 ↗(On Diff #15672)

emplace(username, 1)

1646 ↗(On Diff #15672)

You can += 1 or even just ++ I believe.

1656 ↗(On Diff #15672)

2 blank spaces between return & it.

wraitii added inline comments.Jan 24 2021, 9:15 PM
source/network/NetServer.h
182 ↗(On Diff #15672)

unordered_map

183 ↗(On Diff #15672)

just make it a constexpr int in the .cpp itself

Silier updated this revision to Diff 15673.Jan 24 2021, 9:20 PM

fix comments

Silier marked 3 inline comments as done.Jan 24 2021, 9:21 PM
Silier marked an inline comment as done.
Vulcan added a comment.Jan 24 2021, 9:22 PM

Build is green

builderr-debug-gcc7.txt
../../../source/network/scripting/JSInterface_Network.cpp: In function 'void JSI_Network::StartNetworkJoinLobby(ScriptInterface::CmptPrivate*, const CStrW&, const CStr8&, const CStr8&)':
../../../source/network/scripting/JSInterface_Network.cpp:171:71: warning: unused parameter 'pCmptPrivate' [-Wunused-parameter]
 void JSI_Network::StartNetworkJoinLobby(ScriptInterface::CmptPrivate* pCmptPrivate, const CStrW& playerName, const CStr& hostJID, const CStr& password)
                                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~
builderr-release-gcc7.txt
../../../source/network/scripting/JSInterface_Network.cpp: In function 'void JSI_Network::StartNetworkJoinLobby(ScriptInterface::CmptPrivate*, const CStrW&, const CStr8&, const CStr8&)':
../../../source/network/scripting/JSInterface_Network.cpp:171:71: warning: unused parameter 'pCmptPrivate' [-Wunused-parameter]
 void JSI_Network::StartNetworkJoinLobby(ScriptInterface::CmptPrivate* pCmptPrivate

See https://jenkins.wildfiregames.com/job/docker-differential/4702/display/redirect for more details.

Silier updated this revision to Diff 15674.Jan 24 2021, 9:27 PM

more comments

wraitii added a comment.Jan 24 2021, 9:30 PM

This looks OK to me, but haven't tested, make sure to check it still works after the changes (and forgot about const, sorry)

source/network/NetServer.cpp
1653 ↗(On Diff #15674)
source/network/NetServer.h
171 ↗(On Diff #15674)
Vulcan added a comment.Jan 24 2021, 9:39 PM

Build is green

builderr-debug-gcc7.txt
../../../source/network/scripting/JSInterface_Network.cpp: In function 'void JSI_Network::StartNetworkJoinLobby(ScriptInterface::CmptPrivate*, const CStrW&, const CStr8&, const CStr8&)':
../../../source/network/scripting/JSInterface_Network.cpp:171:71: warning: unused parameter 'pCmptPrivate' [-Wunused-parameter]
 void JSI_Network::StartNetworkJoinLobby(ScriptInterface::CmptPrivate* pCmptPrivate, const CStrW& playerName, const CStr& hostJID, const CStr& password)
                                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~
builderr-release-gcc7.txt
../../../source/network/scripting/JSInterface_Network.cpp: In function 'void JSI_Network::StartNetworkJoinLobby(ScriptInterface::CmptPrivate*, const CStrW&, const CStr8&, const CStr8&)':
../../../source/network/scripting/JSInterface_Network.cpp:171:71: warning: unused parameter 'pCmptPrivate' [-Wunused-parameter]
 void JSI_Network::StartNetworkJoinLobby(ScriptInterface::CmptPrivate* pCmptPrivate

See https://jenkins.wildfiregames.com/job/docker-differential/4703/display/redirect for more details.

Vulcan added a comment.Jan 24 2021, 9:52 PM

Build is green

builderr-debug-gcc7.txt
../../../source/network/scripting/JSInterface_Network.cpp: In function 'void JSI_Network::StartNetworkJoinLobby(ScriptInterface::CmptPrivate*, const CStrW&, const CStr8&, const CStr8&)':
../../../source/network/scripting/JSInterface_Network.cpp:171:71: warning: unused parameter 'pCmptPrivate' [-Wunused-parameter]
 void JSI_Network::StartNetworkJoinLobby(ScriptInterface::CmptPrivate* pCmptPrivate, const CStrW& playerName, const CStr& hostJID, const CStr& password)
                                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~
builderr-release-gcc7.txt
../../../source/network/scripting/JSInterface_Network.cpp: In function 'void JSI_Network::StartNetworkJoinLobby(ScriptInterface::CmptPrivate*, const CStrW&, const CStr8&, const CStr8&)':
../../../source/network/scripting/JSInterface_Network.cpp:171:71: warning: unused parameter 'pCmptPrivate' [-Wunused-parameter]
 void JSI_Network::StartNetworkJoinLobby(ScriptInterface::CmptPrivate* pCmptPrivate

See https://jenkins.wildfiregames.com/job/docker-differential/4704/display/redirect for more details.

Vulcan added a comment.Jan 24 2021, 10:10 PM

Build is green

builderr-debug-macos.txt
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libnetwork_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/liblobby_dbg.a(precompiled.o) has no symbols
../../../source/network/scripting/JSInterface_Network.cpp:171:71: warning: unused parameter 'pCmptPrivate' [-Wunused-parameter]
void JSI_Network::StartNetworkJoinLobby(ScriptInterface::CmptPrivate* pCmptPrivate, const CStrW& playerName, const CStr& hostJID, const CStr& password)
                                                                      ^
1 warning generated.
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libengine_dbg.a(precompiled.o) has no symbols
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/Core

See https://jenkins.wildfiregames.com/job/macos-differential/3043/display/redirect for more details.

Harbormaster completed remote builds in B15392: Diff 15670.Jan 24 2021, 10:11 PM
Vulcan added a comment.Jan 24 2021, 10:18 PM

Build is green

builderr-debug-macos.txt
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libnetwork_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/liblobby_dbg.a(precompiled.o) has no symbols
../../../source/network/scripting/JSInterface_Network.cpp:171:71: warning: unused parameter 'pCmptPrivate' [-Wunused-parameter]
void JSI_Network::StartNetworkJoinLobby(ScriptInterface::CmptPrivate* pCmptPrivate, const CStrW& playerName, const CStr& hostJID, const CStr& password)
                                                                      ^
1 warning generated.
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libengine_dbg.a(precompiled.o) has no symbols
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/Core

See https://jenkins.wildfiregames.com/job/macos-differential/3044/display/redirect for more details.

Harbormaster completed remote builds in B15394: Diff 15672.Jan 24 2021, 10:18 PM
Vulcan added a comment.Jan 24 2021, 10:25 PM

Build is green

builderr-debug-macos.txt
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libnetwork_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/liblobby_dbg.a(precompiled.o) has no symbols
../../../source/network/scripting/JSInterface_Network.cpp:171:71: warning: unused parameter 'pCmptPrivate' [-Wunused-parameter]
void JSI_Network::StartNetworkJoinLobby(ScriptInterface::CmptPrivate* pCmptPrivate, const CStrW& playerName, const CStr& hostJID, const CStr& password)
                                                                      ^
1 warning generated.
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libengine_dbg.a(precompiled.o) has no symbols
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/Core

See https://jenkins.wildfiregames.com/job/macos-differential/3045/display/redirect for more details.

Harbormaster completed remote builds in B15395: Diff 15673.Jan 24 2021, 10:25 PM
Vulcan added a comment.Jan 24 2021, 10:26 PM

Build has FAILED

builderr-debug-macos.txt
In file included from In file included from ../../../source/network/NetServerTurnManager.cpp:22../../../source/network/NetServer.cpp::
../../../source/network/NetServer.h:182:720:
../../../source/network/NetServer.h:: error: 182:no template named 'unordered_map' in namespace 'std'
7: error: no template named 'unordered_map' in namespace 'std'
        std::unordered_map<std::string, int> m_FailedAttempts;
        std::unordered_map<std::string, int> m_FailedAttempts;
        ~~~~~^
        ~~~~~^
In file included from ../../../source/network/NetSession.cpp:24:
../../../source/network/NetServer.h:182:7: error: no template named 'unordered_map' in namespace 'std'
        std::unordered_map<std::string, int> m_FailedAttempts;
        ~~~~~^
../../../source/network/NetServer.cpp:1591:15: error: calling a private constructor of class 'CNetServerWorker'
        m_Worker(new CNetServerWorker(useLobbyAuth, autostartPlayers)),
                     ^
../../../source/netwo

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/3046/display/redirect
See console output for more information: https://jenkins.wildfiregames.com/job/macos-differential/3046/display/redirectconsole

Harbormaster completed remote builds in B15396: Diff 15674.Jan 24 2021, 10:26 PM
Freagarach added a subscriber: Freagarach.Jan 25 2021, 11:12 AM
Freagarach added inline comments.
source/network/NetServer.cpp
1644–1649 ↗(On Diff #15674)

?

Silier updated this revision to Diff 15693.Jan 25 2021, 7:54 PM

const
remove log, not really needed

Vulcan added a comment.Jan 25 2021, 7:56 PM

Build has FAILED

builderr-debug-macos.txt
In file included from In file included from ../../../source/network/NetServerTurnManager.cpp../../../source/network/NetServer.cpp:22::
../../../source/network/NetServer.h20::
182../../../source/network/NetServer.h:182::7: error: no template named 'unordered_map' in namespace 'std'
7: error: no template named 'unordered_map' in namespace 'std'
        std::unordered_map<std::string, int> m_FailedAttempts;
        std::unordered_map<std::string, int> m_FailedAttempts;
        ~~~~~^
        ~~~~~^
In file included from ../../../source/network/NetSession.cpp:24:
../../../source/network/NetServer.h:182:7: error: no template named 'unordered_map' in namespace 'std'
        std::unordered_map<std::string, int> m_FailedAttempts;
        ~~~~~^
../../../source/network/NetServer.cpp:1591:15: error: calling a private constructor of class 'CNetServerWorker'
        m_Worker(new CNetServerWorker(useLobbyAuth, autostartPlayers)),
                     ^
1 error generated.
..

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/3059/display/redirect
See console output for more information: https://jenkins.wildfiregames.com/job/macos-differential/3059/display/redirectconsole

Stan added a subscriber: Stan.Jan 25 2021, 8:02 PM
Stan added inline comments.
source/network/NetServer.h
30 ↗(On Diff #15693)
Silier updated this revision to Diff 15694.Jan 25 2021, 8:02 PM

try to fix macos

Stan added a comment.Jan 25 2021, 8:05 PM

Do you have to use std::string for the username? Can't you use CStr instead?

source/network/NetServer.cpp
1635–1646 ↗(On Diff #15694)
Silier added a comment.Jan 25 2021, 8:09 PM

iq is using std::string, converting it to CStr just for this is bad from my point of view

Vulcan added a comment.Jan 25 2021, 8:10 PM

Build is green

builderr-debug-macos.txt
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libnetwork_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/liblobby_dbg.a(precompiled.o) has no symbols
../../../source/network/scripting/JSInterface_Network.cpp:171:71: warning: unused parameter 'pCmptPrivate' [-Wunused-parameter]
void JSI_Network::StartNetworkJoinLobby(ScriptInterface::CmptPrivate* pCmptPrivate, const CStrW& playerName, const CStr& hostJID, const CStr& password)
                                                                      ^
1 warning generated.
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libengine_dbg.a(precompiled.o) has no symbols
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/Core

See https://jenkins.wildfiregames.com/job/macos-differential/3060/display/redirect for more details.

Stan added a comment.Jan 25 2021, 8:10 PM

And I suppose password is using CStr everywhere else?

Silier added a comment.Jan 25 2021, 8:12 PM

password came from javascript, so was CStr already

Vulcan added a comment.Jan 25 2021, 8:14 PM

Build is green

builderr-debug-gcc7.txt
../../../source/network/scripting/JSInterface_Network.cpp: In function 'void JSI_Network::StartNetworkJoinLobby(ScriptInterface::CmptPrivate*, const CStrW&, const CStr8&, const CStr8&)':
../../../source/network/scripting/JSInterface_Network.cpp:171:71: warning: unused parameter 'pCmptPrivate' [-Wunused-parameter]
 void JSI_Network::StartNetworkJoinLobby(ScriptInterface::CmptPrivate* pCmptPrivate, const CStrW& playerName, const CStr& hostJID, const CStr& password)
                                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~
builderr-release-gcc7.txt
../../../source/network/scripting/JSInterface_Network.cpp: In function 'void JSI_Network::StartNetworkJoinLobby(ScriptInterface::CmptPrivate*, const CStrW&, const CStr8&, const CStr8&)':
../../../source/network/scripting/JSInterface_Network.cpp:171:71: warning: unused parameter 'pCmptPrivate' [-Wunused-parameter]
 void JSI_Network::StartNetworkJoinLobby(ScriptInterface::CmptPrivate* pCmptPrivate

See https://jenkins.wildfiregames.com/job/docker-differential/4717/display/redirect for more details.

Harbormaster completed remote builds in B15414: Diff 15693.Jan 25 2021, 8:14 PM
Vulcan added a comment.Jan 25 2021, 8:30 PM

Build is green

builderr-debug-gcc7.txt
../../../source/network/scripting/JSInterface_Network.cpp: In function 'void JSI_Network::StartNetworkJoinLobby(ScriptInterface::CmptPrivate*, const CStrW&, const CStr8&, const CStr8&)':
../../../source/network/scripting/JSInterface_Network.cpp:171:71: warning: unused parameter 'pCmptPrivate' [-Wunused-parameter]
 void JSI_Network::StartNetworkJoinLobby(ScriptInterface::CmptPrivate* pCmptPrivate, const CStrW& playerName, const CStr& hostJID, const CStr& password)
                                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~
builderr-release-gcc7.txt
../../../source/network/scripting/JSInterface_Network.cpp: In function 'void JSI_Network::StartNetworkJoinLobby(ScriptInterface::CmptPrivate*, const CStrW&, const CStr8&, const CStr8&)':
../../../source/network/scripting/JSInterface_Network.cpp:171:71: warning: unused parameter 'pCmptPrivate' [-Wunused-parameter]
 void JSI_Network::StartNetworkJoinLobby(ScriptInterface::CmptPrivate* pCmptPrivate

See https://jenkins.wildfiregames.com/job/docker-differential/4718/display/redirect for more details.

Harbormaster completed remote builds in B15415: Diff 15694.Jan 25 2021, 8:30 PM
Silier updated this revision to Diff 15710.Jan 26 2021, 7:51 PM

make Stan happy

Vulcan added a comment.Jan 26 2021, 7:58 PM

Build is green

builderr-debug-macos.txt
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libnetwork_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/liblobby_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libengine_dbg.a(precompiled.o) has no symbols
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file

See https://jenkins.wildfiregames.com/job/macos-differential/3072/display/redirect for more details.

Harbormaster completed remote builds in B15432: Diff 15710.Jan 26 2021, 8:08 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jan 26 2021, 9:21 PM
Closed by commit rP24794: Limit possibility of brute force attacks when guessing password (authored by Silier). · Explain Why
This revision was automatically updated to reflect the committed changes.
Silier added a commit: rP24794: Limit possibility of brute force attacks when guessing password.

Revision Contents
Changeset List

PathSize
ps/
trunk/
binaries/
data/
mods/
public/
gui/
gamesetup_mp/
1 line
source/
lobby/
13 lines
network/
19 lines
22 lines
scripting/
2 lines

Diff 15711

View Options

ps/trunk/binaries/data/mods/public/gui/gamesetup_mp/gamesetup_mp.js

Loading...
View Options

ps/trunk/source/lobby/XmppClient.cpp

Loading...
View Options

ps/trunk/source/network/NetServer.h

Loading...
View Options

ps/trunk/source/network/NetServer.cpp

Loading...
View Options

ps/trunk/source/network/scripting/JSInterface_Network.cpp

Loading...
Wildfire Games · Phabricator