[WIP] Improve the selection details UI
Needs ReviewPublic
Actions

Authored by wraitii on Jan 25 2021, 12:07 PM.

Details

Reviewers: None

Summary

See https://github.com/wraitii/ui_mod for download, probably easier than arcanist.
This changes the selection details UI to be more functional.
I'm basically copying the AoE 2 UI, because it has not changed in 22 years and 3 iterations and at this point I think it has a good claim for being perfect.

The most significant change is moving the command icons to the right-hand-side panels, which frees up space in the middle. I think it's better, since:

we still have a few spare building slots
we can have more commands (I believe some units might already need arrows to scroll?)
it's somewhat more logical there IMO.

I also plan to update the multiple-unit selection details, in case all entities are the same, but that'll probably be another diff.

See screenshots:

Test Plan

This is obviously a bit WIP, but the idea is to see how you feel about this.

Diff Detail

Repository

rP 0 A.D. Public Repository

Branch

temp

Lint

Lint OK

Severity	Location	Code	Message
Error	binaries/data/mods/public/gui/session/selection_details.js:338	ESLintBear	ESLintBear
Error	binaries/data/mods/public/gui/session/selection_details.js:338	JSHintBear	JSHintBear
Error	binaries/data/mods/public/gui/session/selection_details.js:338	JSHintBear	JSHintBear
Error	binaries/data/mods/public/gui/session/selection_details.js:338	JSHintBear	JSHintBear

Unit

No Unit Test Coverage

Build Status

Buildable 15404
Build 33650: Vulcan Build	Jenkins
Build 33649: Vulcan Build (macOS)	Jenkins
Build 33648: Vulcan Build (Windows)	Jenkins
Build 33647: arc lint + arc unit

Event Timeline

wraitii created this revision.Jan 25 2021, 12:07 PM

Owners added a subscriber: Restricted Owners Package.Jan 25 2021, 12:07 PM

wraitii edited the summary of this revision. (Show Details)Jan 25 2021, 12:08 PM

Build is green

builderr-debug-macos.txt
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framework/CoreVideo.tbd and library file /System/Library/Frameworks//CoreVideo.framework/CoreVideo are out of sync. Falling back to library file for linking.
ld: warning: text-based stu

See https://jenkins.wildfiregames.com/job/macos-differential/3054/display/redirect for more details.

Harbormaster completed remote builds in B15404: Diff 15682.Jan 25 2021, 12:14 PM

wraitii requested review of this revision.Jan 25 2021, 12:14 PM

wraitii added inline comments.Jan 25 2021, 12:34 PM

binaries/data/mods/public/gui/session/selection_details.js
343	I'm showing averaged DPS instead of raw attack or per-damage attack, because I think it's sufficient to get a rough idea of how strong the unit is. My intention is that the "mostly hack/pierce/crush" damage will be conveyed by the icon, which should change depending on melee/ranged/damage type", e.g: A melee hack damage would be a sword A melee mostly pierce damage would be a lance A ranged pierce would be a bow A melee crush a 'ram' icon and so on.

wraitii added inline comments.Jan 25 2021, 12:38 PM

binaries/data/mods/public/gui/session/selection_panels_middle/single_details_area.xml
39	There's really only room for 2 status bars + texts, but I think if we need to show more I could raise the icon correspondingly, and it would work OK (e.g. for fields)