Display locked icon for matches with password, unlocked otherwise.
This should help players to avoid clicking to the locked matches when they do not know password.
Details
Details
- Reviewers
- None
- Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Commits
- rP24795: Add private and public icons to the game list
- Trac Tickets
- #5949
create match with password
create match without password
complain
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
builderr-debug-macos.txt ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking. ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking. ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking. ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framework/CoreVideo.tbd and library file /System/Library/Frameworks//CoreVideo.framework/CoreVideo are out of sync. Falling back to library file for linking. ld: warning: text-based stu
See https://jenkins.wildfiregames.com/job/macos-differential/3065/display/redirect for more details.
Comment Actions
Are you sure the icons are visible and do not clutter the UI?
It would be nice not to abuse feature freeze too much though
| binaries/data/mods/public/gui/lobby/LobbyPage/Game.js | ||
|---|---|---|
| 150 ↗ | (On Diff #15700) | Why do you profile this? |
| binaries/data/mods/public/gui/lobby/icons/lobby_icons.xml | ||
| 1 ↗ | (On Diff #15700) | Name is a lot redundant with folder names... |
| binaries/data/mods/public/gui/page_lobby.xml | ||
| 9 ↗ | (On Diff #15700) | Why include whole folder ? |
| binaries/data/mods/public/gui/lobby/icons/lobby_icons.xml | ||
|---|---|---|
| 1 ↗ | (On Diff #15700) | Yeah, one can just split this into private and public.xml. |
| binaries/data/mods/public/gui/lobby/icons/lobby_icons.xml | ||
|---|---|---|
| 1 ↗ | (On Diff #15700) | Or just have an icons.xml in the lobby folder |
Comment Actions
I think this is reasonably "bug fix" enough, to be honest, because if a lot of games are private it'll become frustrating. In fact, we probably will need to add an option to filter them out in the future.
Code looks not buggy, would be nice to test.
Comment Actions
Build is green
builderr-debug-macos.txt /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libsimulation2_dbg.a(precompiled.o) has no symbols /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libengine_dbg.a(precompiled.o) has no symbols /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgraphics_dbg.a(precompiled.o) has no symbols /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgui_dbg.a(precompiled.o) has no symbols ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking. ld: warning: text-based stub file /System/Library/Fra
See https://jenkins.wildfiregames.com/job/macos-differential/3071/display/redirect for more details.