Page MenuHomeWildfire Games

Fix Z-fight in the menu
ClosedPublic

Authored by wraitii on Jan 28 2021, 5:34 PM.

Details

Reviewers
None
Commits
rP24825: Fix Z-fight in the menu
Summary

Fixes rP24667

Reported by: Vladislavbelov

Test Plan

Open the menu.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

wraitii created this revision.Jan 28 2021, 5:34 PM

Build is green

builderr-debug-macos.txt
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framework/CoreVideo.tbd and library file /System/Library/Frameworks//CoreVideo.framework/CoreVideo are out of sync. Falling back to library file for linking.
ld: warning: text-based stu

See https://jenkins.wildfiregames.com/job/macos-differential/3105/display/redirect for more details.

wraitii requested review of this revision.Jan 28 2021, 5:41 PM

Does it work with popups? Like chats, charts, messages, tutorials (other popup-like pages)?

wraitii added a comment.EditedJan 29 2021, 1:06 PM

Does it work with popups? Like chats, charts, messages, tutorials (other popup-like pages)?

As far as I can tell none of those hide (or should hide) the top panel anyways.

Edit: and as I post this I realise that maybe they do at lower resolution, I'll check.

wraitii abandoned this revision.Jan 29 2021, 2:33 PM

It does indeed. I think D3386 was the proper fix in the first place, then.

It does indeed. I think D3386 was the proper fix in the first place, then.

I can't call it proper, working - maybe, proper - definitely not.

wraitii reclaimed this revision.Jan 29 2021, 2:39 PM

Accurate. I don't think I have a choice but to explicitly specify Z everywhere...

wraitii updated this revision to Diff 15767.Jan 29 2021, 3:13 PM

Forgot that there, in fact, was a menu button GUI item for this.

Build is green

builderr-debug-macos.txt
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libnetwork_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/liblobby_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libglooxwrapper_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libengine_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgraphics_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../

See https://jenkins.wildfiregames.com/job/macos-differential/3117/display/redirect for more details.

This revision was not accepted when it landed; it landed in state Needs Review.Feb 3 2021, 12:01 PM
Closed by commit rP24825: Fix Z-fight in the menu (authored by wraitii). · Explain Why
This revision was automatically updated to reflect the committed changes.