The specific names are often confusing for translators, as a quick forum search can show. This patch therefore excludes them from the buildings, units, misc. templates, and technologies groups and groups them together in a new separate specific names group.
Moreover, it allows adding a context to the <SpecificName> nodes in templates, and it adds a context to the specific names of all animals, because those are modern scientific names, not transliterations of a name in an ancient language.
The idea of adding a context was raised in D2995. D3491 showed which file needed to be edited.
As a consequence all specific names will probably have to be retranslated, but that should be actually less work than it might seem, since most languages just copy-paste the original string or leave them untranslated.
Details
- Reviewers
- None
- Group Reviewers
Restricted Owners Package (Owns No Changed Paths)
Check carefully and critically. I think it should work, but haven't (and couldn't) tested.
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- /ps/trunk
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 15479 Build 33912: Vulcan Build Jenkins Build 33911: Vulcan Build (macOS) Jenkins Build 33910: Vulcan Build (Windows) Jenkins Build 33909: arc lint + arc unit
Event Timeline
| binaries/data/mods/public/l10n/messages.json | ||
|---|---|---|
| 557 | Or maybe omit -templates-? | |
Build is green
builderr-debug-macos.txt ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking. ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking. ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking. ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framework/CoreVideo.tbd and library file /System/Library/Frameworks//CoreVideo.framework/CoreVideo are out of sync. Falling back to library file for linking. ld: warning: text-based stu
See https://jenkins.wildfiregames.com/job/macos-differential/3109/display/redirect for more details.
I agree with this change. Pinging @Gallaecio just in case.
| binaries/data/mods/public/l10n/messages.json | ||
|---|---|---|
| 557 | Well, if you include the technologies (as you've done), I agree ;) | |
| 582 | ? | |
| binaries/data/mods/public/l10n/messages.json | ||
|---|---|---|
| 582 | JSON and XML work differently. I don't think it's possible to have a context in technology files. Adding comments in the file is not possible either. | |
If many languages don’t touch these translations, I think it’s good to move them to a separate file to make the life of those translators easier.
However, I believe the use of context here may not be as intended: https://code.wildfiregames.com/D3491#154257