No more bright yellow player color
ClosedPublic
Actions

Authored by Grugnas on Apr 17 2017, 7:31 PM.

Details

Reviewers

niektb
elexis

Summary

Yellow color is very bright and, sometimes it is difficult to notice fight engages in the minimap because the attack related blinking dot is hard to distinguish.

Test Plan

Yellow Player recolor (it is kinda golden now, darker than the original in order to make a wider gap between metal and the player units, expecially while blinking).

Comparison between Old and New Yellow color

Diff Detail

Repository

rP 0 A.D. Public Repository

Branch

/ps/trunk

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 1853
Build 2933: Vulcan Build	Jenkins
Build 2932: arc lint + arc unit

Event Timeline

Grugnas created this revision.Apr 17 2017, 7:31 PM

Grugnas edited the test plan for this revision. (Show Details)

Grugnas edited the summary of this revision. (Show Details)Apr 17 2017, 11:59 PM

Grugnas edited the test plan for this revision. (Show Details)

Player yellow color only upload.

Harbormaster completed remote builds in B1853: Diff 2080.May 21 2017, 1:27 PM

Owners added a subscriber: Restricted Owners Package.May 21 2017, 1:27 PM

Grugnas retitled this revision from [Proposal] minimap colors revist to No more bright yellow player color.May 21 2017, 1:31 PM

Grugnas edited the summary of this revision. (Show Details)

Grugnas edited the test plan for this revision. (Show Details)

Can't we fix all the other colors on the fly too? (and make sure this new yellow fits in properly with the other enhanced colors)

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/1284/ for more details.

Harbormaster completed remote builds in B1853: Diff 2080.May 21 2017, 6:21 PM

elexis accepted this revision.May 24 2017, 2:18 AM

This revision is now accepted and ready to land.May 24 2017, 2:18 AM

Already fixed by rP19819?

Yes it is fixed by that commit

Grugnas closed this revision.Jun 25 2017, 11:19 PM