Fix Missing props for the old athen fortress
ClosedPublic
Actions

Authored by Stan on Apr 17 2017, 8:25 PM.

Details

Reviewers

enrique
fatherbushido

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rP19509: Fix Missing props for the old athen fortress. Patch by Stan.

Trac Tickets

#2524

Summary

Since rP19280 Enrique deleted one of the file containing the props for the old athenian fortress hereby causing a warning when running the script.pl
This patch readds the file, fix the missing dependencies, remove the ao in the material as the old fortress didn't have ao, and that would crash Atlas instantly if loaded (something should be done for that in another ticket at some point)

Test Plan

Run the scripts.pl

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Stan created this revision.Apr 17 2017, 8:25 PM

fatherbushido edited the summary of this revision. (Show Details)Apr 20 2017, 7:38 AM

binaries/data/mods/public/art/actors/special/old/athenian_fortress.xml
8 ↗	(On Diff #1311)	Uhm it seems we should use specific shields, isn't it? (see the other hellenic fortress too).
10 ↗	(On Diff #1311)	Shouldn't we instead change that in props/structures/hellenes/fortress_props_up.xml? That's what was done for the other in the previous commit you cited in description.

Stan added inline comments.Apr 20 2017, 8:31 AM

binaries/data/mods/public/art/actors/special/old/athenian_fortress.xml
8 ↗	(On Diff #1311)	I don't think there is or if there was it was deleted.
10 ↗	(On Diff #1311)	Yeah because props whatever up are the for the new fortress models. So no we can't use the up version. I tried.

fatherbushido added inline comments.Apr 20 2017, 9:08 AM

binaries/data/mods/public/art/actors/special/old/athenian_fortress.xml
8 ↗	(On Diff #1311)	I just checked, there are.

Actually I checked, and the athenians shield don't fit the model at all.

fatherbushido edited reviewers, added: Restricted Owners Package; removed: fatherbushido.Apr 23 2017, 2:58 PM

Well it fixes and passed now the different tools. I checked in atlas.
Thanks for the patch.

This revision is now accepted and ready to land.May 4 2017, 11:13 AM

Closed by commit rP19509: Fix Missing props for the old athen fortress. Patch by Stan. (authored by fatherbushido). · Explain WhyMay 4 2017, 11:13 AM

This revision was automatically updated to reflect the committed changes.

See rP19510

Revision Contents
Changeset List

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

art/

actors/

special/

old/

athenian_fortress.xml

8 lines

Diff 1640

View Options

ps/trunk/binaries/data/mods/public/art/actors/special/old/athenian_fortress.xml

Fix Missing props for the old athen fortressClosedPublicActions