As indicated in trac #3512, only Petra send a notification.
- Add a new option for chat notification.
- Send a notification when the phase is started and is reached.
Differential D354
Send a phase up notification to your teammates Polakrity on Apr 18 2017, 12:39 AM. Authored by
Details
As indicated in trac #3512, only Petra send a notification.
Test plan: Test all POV (observer, user, allies, ennemy) if the notification is sent.
Diff Detail
Event TimelineComment Actions
Comment Actions
Thanks to elexis for the reviews and the help Comment Actions why not showing earlier when starts to phase due to make planing for things afterwards... inteam Comment Actions I would be nice to at least run a SP game with the proposed patch before uploading it.
Comment Actions Change the boolean type by a dropdown in options with 3 news values. Comment Actions None of the people I have asked (Polakrity, mimo, fatherbushido, wraitii, bb, Hannibal Barca and ffffffff) have a strong opinion. A notification should occur as soon as possible (so therefore the start notification is intuitively the one we want), Either show only the completed one or add the option to allow players chosing between none, finished and both,. Comment Actions Ah didn't get the update
Comment Actions What kind of problem do you mean? if it is because it breaks compatibility with previous saved games, that can be expected and not a worry. Comment Actions @mimo: reverting not fixing. it was a bad choice of word. ;)
Comment Actions Build is green Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! http://jw:8080/job/phabricator/839/ for more details. Comment Actions Build is green Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! http://jw:8080/job/phabricator/840/ for more details. Comment Actions
Comment Actions Build is green Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! http://jw:8080/job/phabricator/853/ for more details. Comment Actions Build is green Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! http://jw:8080/job/phabricator/854/ for more details. Comment Actions
Comment Actions Build is green Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! http://jw:8080/job/phabricator/857/ for more details. Comment Actions Build is green Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! http://jw:8080/job/phabricator/862/ for more details. Comment Actions The boolean argument seems to be the best option. This way we can control in the caller when we want to have a notification and when not, without repeating the guiinterface push notification call and without changing the code flaw oddly. Thanks for the patch, I have waited many months for that! Comment Actions Also notice we might want to extend this to arbitrary technologies in the future, in which case we have to rename the phaseName and phaseState part,remove the startsWith("phase") check and then let the user config decide which things will be displayed, potentially changing the strings.
|