Currently which units a civ can train at a civic centre does not only depend on the player's civ, but also on the centre's civ, e.g. cart players can train all their starting units at a kush of maur centre (and vice versa), but none at a mace or ptol centre, which is rather inconsistent.
The reason for this is that each civ specific civic centre file defines their own training queue. Defining all starter units (pikemen, spearmen, swordsmen, etc.) in the generic template_structure_civic_civil_centre.xml would result in all civs being able to train more unit types than their starter units (cf. barracks), which is undesirable too.
This patch addresses it by introducing three new unit templates for each civ:
default_infantry_melee_b.xml default_infantry_ranged_b.xml default_cavalry.xml
Their file names match the skirmish unit placeholders (using those directly causes errors). This has the following advantages:
- It's no longer necessary to list skirmish replacers for these in the {civ}.json files.
- The civ-specific civic centre queues are cleaned up.
- Players can train their three starter unit types at any civic centre, regarless of civs, and exactly those, no other soldiers.