Changing the value "scroll speed" is not intuitive. Nothing is displayed on the screen, indicating that hotkey is worked
Patch types the value to js console
Details
- Reviewers
- None
- Commits
- rP25045: Adds logs to CameraController for speed changes of camera scroll, rotate andβ¦
.
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Good idea π
If you can, I would suggest using "Translate" around the string so that it gets translated.
I think "increased/decreased" would be more natural, but I'm not 100% sure.
Why not all camera speed changes are printed?
build/premake/premake5.lua | ||
---|---|---|
782 β | (On Diff #16402) | Is it required? |
source/graphics/CameraController.cpp | ||
685 β | (On Diff #16402) | It'd be good to print at least one digit after the point. It's not a fixed point number, so x + y - y might be not equal to x. And with rounding it's unclear. |
to %0.1f
build/premake/premake5.lua | ||
---|---|---|
782 β | (On Diff #16402) | CameraController.cpp from ../../../source/graphics/CameraController.cpp:24: ../../../source/lib/external_libraries/tinygettext.h:36:10: fatal error: tinygettext/tinygettext.hpp: No such file ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ |
Few notes after testing:
- Unfortunately L10n still depends on icu, so I added it to premake to not break --without-pch
- Missed include of ps/CLogger.h
- m_ViewRotate*Speed should have been printed for both components: X and Y
The rest looks good.
- m_ViewRotate*Speed should have been printed for both components: X and Y
I have never seen AAA-games where when changing a parameter it said "Rotate speed decreased to X = 1.025, Y = 1.328".
The author of the patch should decide for himself whether he creates a debug function or improves the game experience.
Please give a response time next time.
The rest looks good
Thanks for your time
The code changes both parameters, so it should print both. Else it's misleading a player. I'm not sure that there're AAA games with detailed logs - they're too technical for a player. Usually all such adjustments are done by sliders in settings.
The author of the patch should decide for himself whether he creates a debug function or improves the game experience.
I'm not sure that I get what do you mean.
Thanks for your time
Thanks for the patch!