Don't try to get the capture points of a destroyed entity in StatusBar
ClosedPublic
Actions

Authored by fatherbushido on Apr 19 2017, 12:09 PM.

Details

Reviewers

sanderd17
• leper
elexis

Commits

rP19451: Don't try to get capture points and add capture bar of a destroyed entity in…

Summary

Perhaps ideally, we should not have to check here.

Test Plan

Take macedonians, build demetrius hero and a boltshooter.
Unpack/Pack or destroy the boltshooter.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

fatherbushido created this revision.Apr 19 2017, 12:09 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/822/ for more details.

Harbormaster completed remote builds in B1191: Diff 1357.Apr 19 2017, 1:54 PM

fatherbushido mentioned this in D143: Don't regenerate status bars for destroyed entities..Apr 23 2017, 2:19 PM

sanderd17 accepted this revision.Apr 23 2017, 4:13 PM

This revision is now accepted and ready to land.Apr 23 2017, 4:13 PM

Closed by commit rP19451: Don't try to get capture points and add capture bar of a destroyed entity in… (authored by fatherbushido). · Explain WhyApr 24 2017, 9:31 PM

This revision was automatically updated to reflect the committed changes.