Page MenuHomeWildfire Games

New map - Botswanan Haven
ClosedPublic

Authored by Hannibal_Barca on Apr 19 2017, 8:00 PM.

Details

Summary

New map created by me from Rhine Marshlands. Many actors and wildlife, few trees. Overall looks like a fun map to play, grass and actors make it pleasing to the eyes.

Possible description:
"Botswanan Africa during the wet season, a land which was arid and inhospitable just weeks before has come to life totally transformed. Herds of zebras graze amid the tall, lush grasses in which lions lie waiting, while in the shallow pools lurk fearsome crocodiles."

Test Plan

Test map for resource collisions and the usual stuff.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 1200
Build 1900: Vulcan BuildJenkins

Event Timeline

Hannibal_Barca created this revision.Apr 19 2017, 8:00 PM
Vulcan added a subscriber: Vulcan.Apr 19 2017, 9:04 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/829/ for more details.

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/880/ for more details.

Lionkanzen added a subscriber: elexis.
elexis edited edge metadata.Apr 29 2017, 1:40 AM

Hannibal proposed "Botswanan Paradise/Haven".
"Botswanan Haven" sounds indeed better than another Africa in the mapname

Changed name to Botswanan Haven

Hannibal_Barca retitled this revision from New map - African Wetseason to New map - Botswanan Haven.May 1 2017, 10:43 AM
Hannibal_Barca edited the summary of this revision. (Show Details)

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/952/ for more details.

elexis accepted this revision.May 9 2017, 9:56 PM

Good that we found the crash beforehand -> #4563.
Inlining all of these group/placer/... calls wasn't fun.
Never saw those shrub_tropic_plant_flower before, nice one.
Increased the mud size so it looks less monotonous.
Thanks for the great map material!

binaries/data/mods/public/maps/random/botswanan_haven.js
26 ↗(On Diff #1579)

(16:31:53) elexis: did you check that all those animals actually occur in botswana?
(16:32:14) Hannibal_Baraq: rhino did
(16:32:21) elexis: wildebeest, lion, gazelle, zebra, crocodile, rhino, rabbit
(16:32:22) Hannibal_Baraq: elephants yes, zebras
(16:32:28) Hannibal_Baraq: wildebeest yes
(16:32:32) Hannibal_Baraq: crocodiles remember
(16:32:36) Hannibal_Baraq: rabbits probably
(16:32:43) Hannibal_Baraq: gazelle was

71 ↗(On Diff #1579)
72 ↗(On Diff #1579)

playerAngle used only in the loop, so can become a local variable

200 ↗(On Diff #1579)

This loop is as awkward as on rhine marshlands, since one iteration already places a number of marshes all over the map

208 ↗(On Diff #1579)

Nothing ever reads waterAreas, so no need to store the result at all

220 ↗(On Diff #1579)

This call spawns wa too many reeds and causes a crash! #4563

243 ↗(On Diff #1579)

So 800 trees of which 30% should become stragglers and then not placing the rest. Seems very thought through

246 ↗(On Diff #1579)

Why do we define numStragglers in L246 and not use it until after L400?

255 ↗(On Diff #1579)

the patches should be large, otherwise that one texture is too predominant

409 ↗(On Diff #1579)

randInt is deprecated, use randIntInclusive / Exclusive

This revision is now accepted and ready to land.May 9 2017, 9:56 PM
This revision was automatically updated to reflect the committed changes.