Page MenuHomeWildfire Games

Custom replay date/time filter #4249

Authored by rob-v on Apr 20 2017, 11:09 PM.


Trac Tickets

Replaces yyyy-mm dropdown by textbox. Can be used to filter by yyyy, yyyy-mm, yyyy-mm-dd,..... replay time.

Test Plan

In Replays window, type yyyy... to filter by year, month or day,...

Diff Detail

Lint Skipped
Unit Tests Skipped

Event Timeline

rob-v created this revision.Apr 20 2017, 11:09 PM
Vulcan added a subscriber: Vulcan.Apr 20 2017, 11:11 PM

Build has FAILED

Link to build: http://jw:8080/job/phabricator/837/
See console output for more information: http://jw:8080/job/phabricator/837/console

rob-v updated this revision to Diff 1393.Apr 21 2017, 10:10 AM

Fixed EOLN

elexis added a subscriber: elexis.Apr 21 2017, 2:08 PM

Should explain the user how to use it, there was also some CInput.cpp patch that would allow showing a gray text that doesn't have an effect, like YYYY-MM-DD, would be nice to wait for that. Otherwise looks good at first sight

elexis added a subscriber: Imarok.Dec 7 2017, 3:09 PM

Since rP20091 we also have the TextEdit GUI event, so we don't require the user anymore to press enter.
Unfortunately it's laggy, so it should be optional, or simply not used.

Actually I found it more comfortable to have a dropdown with months when changing the filter repeatedly. You almost always have to type the same year, which are 5 keystrokes where in the other case one click and 5 mousewheel scrolls (i.e. 5x the same button), which is considerably easier and relevant when repeating it often.

Also we can't search for specific patterns, like *-12-* or only -12-.

rob-v abandoned this revision.Dec 29 2018, 5:06 PM