Posted also in the forum. I can't use arcanist with it due to the renamed file.
Details
agreed by scyte.
Posted here for inline comment.
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Build is green
Updating workspaces. Build (release)... ../../../source/gui/CChart.cpp:38:41: warning: unused parameter ‘Message’ [-Wunused-parameter] void CChart::HandleMessage(SGUIMessage& Message) ^ ../../../source/lib/tex/tex_png.cpp: In member function ‘virtual Status TexCodecPng::encode(Tex*, DynArray*) const’: ../../../source/lib/tex/tex_png.cpp:309:9: warning: variable ‘ret’ might be clobbered by ‘longjmp’ or ‘vfork’ [-Wclobbered] Status ret = ERR::FAIL; ^ Build (debug)... ../../../source/gui/CChart.cpp:38:41: warning: unused parameter ‘Message’ [-Wunused-parameter] void CChart::HandleMessage(SGUIMessage& Message) ^ Running debug tests... Running cxxtest tests (302 tests)..............................................................................................................................................................................................................................................................................................................OK!
http://jw:8080/job/phabricator/89/ for more details.
Mentioned forum thread: https://wildfiregames.com/forum/index.php?/topic/21371-adding-auras-to-easter-egg-hero-regicide-mode/
Wouldn't mind seeing more unit variety and thinking about making those bugs features, but that's not the scope of this diff.
Ack on the balancing and approach.
binaries/data/mods/public/simulation/data/auras/iber_hero_viriato.json | ||
---|---|---|
7 ↗ | (On Diff #128) | Resilience doesn't fit to a faster training time in my opinion. Under that name I would suggest that units endure longer (i.e. die less quickly, i.e more HP or armor). |
10 ↗ | (On Diff #128) | Newline at end of file |
binaries/data/mods/public/simulation/data/auras/mace_hero_craterus.json | ||
6 ↗ | (On Diff #128) | Wasn't there a recent commit about adding all attack classes to make it more consitent? |
binaries/data/mods/public/simulation/data/auras/mace_hero_pyrrhus.json | ||
12 ↗ | (On Diff #128) | Since this game is also supposed to be about history education, we should not just write the pure balancing effects but also explain the idea and reasoning behind them: From wiki/Pyrrhic_victory:
|
binaries/data/mods/public/simulation/data/auras/ptol_hero_cleopatra_2.json | ||
10 ↗ | (On Diff #128) | Perhaps quickly check at transifex whether there are requests for capitalization changes. Some brief historical otherwise immersive text wouldn't hurt in case you have some ref. |
binaries/data/mods/public/simulation/templates/units/mace_hero_craterus.xml | ||
6 ↗ | (On Diff #128) | This guy doesn't have a history tag, wouldn't hurt to add one, if we have the resources for that. Perhaps we should ask on the cited forum thread quickly since some of these auras comes from wowgetoffyourcellphone's mod. From Craterus
|
binaries/data/mods/public/simulation/data/auras/iber_hero_viriato.json | ||
---|---|---|
7 ↗ | (On Diff #128) | Dunno wich one fits better to the history tag of that hero (I will not copy it here). |
binaries/data/mods/public/simulation/data/auras/mace_hero_craterus.json | ||
6 ↗ | (On Diff #128) | Yes, I will add them if ever... |
binaries/data/mods/public/simulation/data/auras/mace_hero_pyrrhus.json | ||
12 ↗ | (On Diff #128) | It doesn't fit in auraDescription. |
binaries/data/mods/public/simulation/templates/units/mace_hero_craterus.xml | ||
6 ↗ | (On Diff #128) | Let's adress that for another ticket / patch. |
Well, then sorry for wasting your time mostly ;) Didn't test, but I assume you know what you're doing.
binaries/data/mods/public/simulation/data/auras/iber_hero_viriato.json | ||
---|---|---|
7 ↗ | (On Diff #128) | Not convinced, if units die like and reproduce like flies, they can't be considered resilient. But the name can be used, I don't mind. |
binaries/data/mods/public/simulation/data/auras/mace_hero_craterus.json | ||
6 ↗ | (On Diff #128) | It would be consistent with that one http://trac.wildfiregames.com/changeset/19052/ps/trunk/binaries/data/mods/public/simulation/data/auras/brit_hero_boudicca.json for example. Also applies to the next aura. |
binaries/data/mods/public/simulation/data/auras/mace_hero_pyrrhus.json | ||
12 ↗ | (On Diff #128) | Hm, you are right that this field should remain as brief as possible, at least all other auraDescription entries besides the following avoid storytelling:
Perhaps "Achieve victory with devastating tolls. All soldiers...." would still be short, but we can leave it out too to to focus on the gameplay effects. |
Fix some stuff with previous remarks. For the moment don't add Iberian and Scipio auras.
Address some remarks and fix some stuff. I will wait a bit before adding that(those) Iberians(s) auras and the Roman Scipio's one (or placeholder) .
Build is green
Updating workspaces. Build (release)... Build (debug)... Running debug tests... Running cxxtest tests (302 tests)..............................................................................................................................................................................................................................................................................................................OK!
http://jw:8080/job/phabricator/120/ for more details.
Build is green
Updating workspaces. Build (release)... Build (debug)... Running debug tests... Running cxxtest tests (302 tests)..............................................................................................................................................................................................................................................................................................................OK!
http://jw:8080/job/phabricator/121/ for more details.
Build has FAILED
Link to build: http://jw:8080/job/phabricator/122/
See console output for more information: http://jw:8080/job/phabricator/122/console