Page MenuHomeWildfire Games

Remove duplicate function in TechnologyManager
ClosedPublic

Authored by Polakrity on Apr 23 2017, 12:14 AM.

Details

Summary

I noticed a duplicate function in TechnologyManager.js.
Now, the function is called "GetStartedTechs"

Test Plan

Be certain to replace all calls of the function.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Polakrity created this revision.Apr 23 2017, 12:14 AM
elexis accepted this revision.Apr 23 2017, 2:22 AM

Patch correct because those two functions were identical.
Patch complete because there are no more occurances of GetTechsStarted, nor GetStartedResearch and all prior ones have been renamed to GetStartedTechs.

Thanks for reporting, fixing and extracting this from D354 into a separate patch.

This revision is now accepted and ready to land.Apr 23 2017, 2:22 AM

and rP13225 introduced the duplicate

This revision was automatically updated to reflect the committed changes.
Vulcan added a subscriber: Vulcan.Apr 23 2017, 4:33 AM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/868/ for more details.