I noticed a duplicate function in TechnologyManager.js.
Now, the function is called "GetStartedTechs"
Details
Details
Be certain to replace all calls of the function.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Patch correct because those two functions were identical.
Patch complete because there are no more occurances of GetTechsStarted, nor GetStartedResearch and all prior ones have been renamed to GetStartedTechs.
Thanks for reporting, fixing and extracting this from D354 into a separate patch.
Comment Actions
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
http://jw:8080/job/phabricator/868/ for more details.