For mixed maps (random/fixed fractions), the alignment difference is noticeable
The game mistakenly offers to select a faction for a fixed value
The patch removes the "tooltip on the text" - did not find the application of this tooltip on the page
Details
Details
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Event Timeline
Comment Actions
(Do we still have mixed maps in the current gamesetup iteration?)
The patch removes the "tooltip on the text" - did not find the application of this tooltip on the page
It's there if you load up a scenario map -> you'll see you no longer have a tooltip with the patch if you hover the value, only the text.
I don't think this should be changed, rather you probably should change the Civ tooltip if the civ is fixed.
Comment Actions
No. This is a custom map. Everywhere 0ad is positioned not only as a game but also as a means for creativity (mapmaking/modding)
Moreover, I did not understand the design idea - why for a random on the left and for a fixed in the center
It's there if you load up a scenario map -> you'll see you no longer have a tooltip with the patch if you hover the value, only the text.
I don't think this should be changed, rather you probably should change the Civ tooltip if the civ is fixed.
Ok. My mistake
Comment Actions
Sure, I was just wondering & I also wasn't sure if this would work right now - definitely something we want to support IMO.
Comment Actions
Couldn't find a description for the term "IMO"....
Updated the patch - instead of removing tooltip, update the tooltip during rendering
Comment Actions
"In my opinion". I tend to use too many acronyms, sorry.
I think the civ description is a good idea, see inline.
| binaries/data/mods/public/gui/gamesetup/Pages/GameSetupPage/GameSettings/PerPlayer/Dropdowns/PlayerCiv.js | ||
|---|---|---|
| 33 | Wouldn't it be easier to just call setTooltip directly here? | |
Comment Actions
I tested it - a bad way. For dropdowns, the "random" tooltip filled with wrong value...
Comment Actions
works as described, The code looks fine and I didn't notice any problems when testing.
I'm ok with keeping everything left-aligned.
Comment Actions
yes the tooltip change looks fine. I will test it one more time and commit it if I can't find any bugs.
Comment Actions
hm actually, the tool tip change doesn't work perfectly.
If one selects a scenario map first but then switches to a random map, the tooltips still show the information for the civs from the scenario map, instead of "Choose the civilization for the player". It would need to be updated on change.
Also, while at it we should unify the tooltip style.
| binaries/data/mods/public/gui/gamesetup/Pages/GameSetupPage/GameSettings/PerPlayer/PlayersPanel.xml | ||
|---|---|---|
| 47 | tooltip_style="onscreenToolTip" to make it consistent | |