Page MenuHomeWildfire Games

Fix several missing translatation with context in tooltip
ClosedPublic

Authored by nwtour on Mar 26 2021, 1:14 PM.

Details

Summary

  1. logical error: ternary operator (ctx ? (ctx || "String") : other) where String never execute
  2. applierTooltip in ".po" file with context "status effect" (missing translation)

After applying the patch:

Test Plan

x

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nwtour requested review of this revision.Mar 26 2021, 1:14 PM
nwtour created this revision.
nwtour retitled this revision from Fix missing translatation with context in tooltip to Fix several missing translatation with context in tooltip.Mar 26 2021, 1:16 PM
Nescio added a subscriber: bb.Mar 26 2021, 1:17 PM
wraitii added inline comments.
binaries/data/mods/public/gui/common/tooltips.js
490 ↗(On Diff #16742)

This one probably needs an update as well.

nwtour updated this revision to Diff 16747.Mar 26 2021, 4:53 PM

translate with context receiverTooltip

wraitii accepted this revision.Mar 26 2021, 5:50 PM
This revision is now accepted and ready to land.Mar 26 2021, 5:50 PM
This revision was automatically updated to reflect the committed changes.
Owners added a subscriber: Restricted Owners Package.Mar 26 2021, 5:52 PM