Page MenuHomeWildfire Games

Queueing tech research from structure in selection with lowest queue count
ClosedPublic

Authored by n1xc0d3r on Apr 3 2021, 9:08 AM.

Details

Reviewers
Freagarach
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP25213: Queue techs at structure with the lowest queue length.
Summary

Applying secondary sort based on length of production queue

No ticket exists for this functionality, validated in forum if this was a desired change before submitting

https://wildfiregames.com/forum/topic/37906-distributing-tech-production-across-several-buildings-in-group-selection

Test Plan

No unit tests currently exist, tested manually

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 16574
Build 37557: arc lint + arc unit

Event Timeline

n1xc0d3r created this revision.Apr 3 2021, 9:08 AM
Owners added a subscriber: Restricted Owners Package.Apr 3 2021, 9:08 AM
n1xc0d3r requested review of this revision.Apr 3 2021, 9:08 AM
wraitii added a subscriber: wraitii.Apr 3 2021, 9:10 AM

(You don't have to abandon/recreate a new diff to make changes, you can just update an existing one)

I realize that now :)

It works and I find it useful. Thanks. In the GIF below I had four forges selected and started exploring all 4 items. This worked well. If I only selected 3 forges and explored 4 items, the order was slightly off, once I selected the fourth, it still explored all the things I had selected in the correct order, I just noticed this little visually awkward side effect. When two forges are selected, it does it twice.

PS: This wiki article describes how to update a patch wiki/Phabricator.

Freagarach added a reviewer: Restricted Owners Package.Apr 4 2021, 7:34 AM

The visual artefact seems like a very small price to pay for the improved UX, so I think this could be merged as is.
@n1xc0d3r, could you please add yourself to the credits and update this patch (good exercise) with that? (binaries/data/mods/public/gui/credits/texts/programming.json)

n1xc0d3r updated this revision to Diff 16950.Apr 6 2021, 9:25 PM

added myself to the list of contributors

Langbart added a subscriber: elexis.Apr 8 2021, 4:21 PM

I think to implement this in the game you need to bug a developer as described:

The only thing that gets a patch committed is a team member that stops working on his own feature to review something. That often means repeated begging.

[...] you must nag someone with commit access

Otherwise it might be forgotten.

Freagarach accepted this revision.Apr 8 2021, 4:25 PM

Nice feature, thanks for the patch!
(I'll put your name in the correct place when committing.)

binaries/data/mods/public/gui/credits/texts/programming.json
283 ↗(On Diff #16950)

Alphabetically.

This revision is now accepted and ready to land.Apr 8 2021, 4:25 PM
This revision was automatically updated to reflect the committed changes.