Page MenuHomeWildfire Games

add Spartan team bonus
ClosedPublic

Authored by Grugnas on Apr 24 2017, 3:56 PM.

Details

Test Plan

+10% health for allied citizen soldier infantry spearmen

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Grugnas created this revision.Apr 24 2017, 3:56 PM
elexis added a subscriber: elexis.Apr 24 2017, 4:05 PM
elexis added inline comments.
binaries/data/mods/public/simulation/data/auras/teambonuses/spart_player_teambonus.json
6 ↗(On Diff #1476)

Since it only affects citizens, seems okay, not OP.

9 ↗(On Diff #1476)

It is contested to have it in the same string , but it would be nice to have one sentence of historical background / reasoning, so that players have something to learn from that gameplay bonus.

binaries/data/mods/public/simulation/templates/special/player_spart.xml
5 ↗(On Diff #1476)

Should end with newline

fatherbushido added inline comments.Apr 24 2017, 4:19 PM
binaries/data/mods/public/simulation/data/auras/teambonuses/spart_player_teambonus.json
9 ↗(On Diff #1476)

It's on the civ file. Should be displayed sooner or later.

Grugnas updated this revision to Diff 1477.Apr 24 2017, 4:33 PM

added newline in the xml file

elexis added inline comments.Apr 24 2017, 4:36 PM
binaries/data/mods/public/simulation/data/auras/teambonuses/spart_player_teambonus.json
9 ↗(On Diff #1476)

spart.json says

			"Name":"Peloponnesian League",
			"History":"Much of the Peloponnese was subject to Sparta in one way or another. This loose confederation, with Sparta as its leader, was later dubbed the Peloponnesian League by historians, but in ancient times was called 'The Lacedaemonians and their allies.'",
			"Description":"Allies can train Spartiates."

So the patch should fix that description. Still would be nice to have players become educated, but it's indeed better to have it consistent for all team bonuses.

fatherbushido accepted this revision.Apr 25 2017, 4:25 PM

I will (I hope) fix formal things when commiting.

This revision is now accepted and ready to land.Apr 25 2017, 4:25 PM
This revision was automatically updated to reflect the committed changes.