Page MenuHomeWildfire Games

add Spartan team bonus
ClosedPublic

Authored by Grugnas on Apr 24 2017, 3:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 14, 7:40 PM
Unknown Object (File)
Fri, Sep 13, 12:22 PM
Unknown Object (File)
Fri, Sep 13, 11:06 AM
Unknown Object (File)
Fri, Sep 13, 11:06 AM
Unknown Object (File)
Fri, Sep 13, 7:27 AM
Unknown Object (File)
Tue, Sep 10, 9:58 AM
Unknown Object (File)
Sun, Sep 8, 8:05 AM
Unknown Object (File)
Mon, Sep 2, 10:04 AM
Subscribers

Details

Test Plan

+10% health for allied citizen soldier infantry spearmen

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

elexis added inline comments.
binaries/data/mods/public/simulation/data/auras/teambonuses/spart_player_teambonus.json
6 ↗(On Diff #1476)

Since it only affects citizens, seems okay, not OP.

9 ↗(On Diff #1476)

It is contested to have it in the same string , but it would be nice to have one sentence of historical background / reasoning, so that players have something to learn from that gameplay bonus.

binaries/data/mods/public/simulation/templates/special/player_spart.xml
5 ↗(On Diff #1476)

Should end with newline

binaries/data/mods/public/simulation/data/auras/teambonuses/spart_player_teambonus.json
9 ↗(On Diff #1476)

It's on the civ file. Should be displayed sooner or later.

added newline in the xml file

binaries/data/mods/public/simulation/data/auras/teambonuses/spart_player_teambonus.json
9 ↗(On Diff #1476)

spart.json says

			"Name":"Peloponnesian League",
			"History":"Much of the Peloponnese was subject to Sparta in one way or another. This loose confederation, with Sparta as its leader, was later dubbed the Peloponnesian League by historians, but in ancient times was called 'The Lacedaemonians and their allies.'",
			"Description":"Allies can train Spartiates."

So the patch should fix that description. Still would be nice to have players become educated, but it's indeed better to have it consistent for all team bonuses.

I will (I hope) fix formal things when commiting.

This revision is now accepted and ready to land.Apr 25 2017, 4:25 PM
This revision was automatically updated to reflect the committed changes.