Differential D3829

Fix undefined values in barter tooltip
ClosedPublic
Actions

Authored by nwtour on Apr 10 2021, 3:46 PM.

Details

Reviewers

wraitii

Commits

rP25244: Fix undefined values in barter tooltip.

Summary

Fix undefined values in barter tooltip (see screenshot)

BarterButtonManager return current/first button for fetch BarterResourceSellQuantity/Multiplier

Test Plan

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nwtour requested review of this revision.Apr 10 2021, 3:46 PM

nwtour created this revision.

wraitii accepted this revision.Apr 12 2021, 3:50 PM

This revision is now accepted and ready to land.Apr 12 2021, 3:50 PM

Closed by commit rP25244: Fix undefined values in barter tooltip. (authored by wraitii). · Explain WhyApr 12 2021, 3:51 PM

This revision was automatically updated to reflect the committed changes.

wraitii added a commit: rP25244: Fix undefined values in barter tooltip..

Owners added a subscriber: Restricted Owners Package.Apr 12 2021, 3:51 PM

Revision Contents
Changeset List

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

gui/

session/

trade/

BarterButtonManager.js

7 lines

TradeDialogBarterPanel.js

4 lines

Diff 17056

View Options

ps/trunk/binaries/data/mods/public/gui/session/trade/BarterButtonManager.js