Page MenuHomeWildfire Games

Map browser: input filter, also filter random map entry
ClosedPublic

Authored by nani on Apr 11 2021, 12:13 AM.

Details

Summary

See title

Test Plan

Entry map should filter.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nani requested review of this revision.Apr 11 2021, 12:13 AM
nani created this revision.
nani updated the Trac tickets for this revision.Apr 11 2021, 12:23 AM

I'm not sure what this does? It also seems to not work right, I can't see the "random" option?

Stan added a subscriber: Stan.Wed, Apr 21, 9:49 AM

Thanks for the patch. Can you add context?

binaries/data/mods/public/gui/maps/mapbrowser/grid/MapGridBrowser.js
59 ↗(On Diff #17028)

You might want translate with context here. Single words might not get translated properly without proper context.

wraitii requested changes to this revision.Tue, May 4, 5:26 PM

I understand the "filter random" bit now, but not the rest, and it seems you broke "random" when not using the input filter.
I am still not quite sure what you mean by 'input filter'

This revision now requires changes to proceed.Tue, May 4, 5:26 PM
wraitii updated this revision to Diff 17385.Tue, May 4, 5:53 PM

Doing it myself since there's a few other issues.

  • Random is filtered correctly
  • When in 'fallback to all' mode, selecting something works (#6165).
  • Fix hotkeys being broken.
  • Clear filters when reopening the map browser (seems natural).
Owners added a subscriber: Restricted Owners Package.Tue, May 4, 5:53 PM
wraitii updated this revision to Diff 17386.Tue, May 4, 5:55 PM

Translate with context and don't bring in code already committed. Merging once green.

This revision was not accepted when it landed; it landed in state Needs Review.Tue, May 4, 6:40 PM
This revision was automatically updated to reflect the committed changes.
nani awarded a token.Tue, May 4, 9:08 PM