Page MenuHomeWildfire Games

Fix translation of damage types
ClosedPublic

Authored by nwtour on Apr 14 2021, 12:57 AM.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nwtour requested review of this revision.Apr 14 2021, 12:57 AM
nwtour created this revision.
Freagarach set the repository for this revision to rP 0 A.D. Public Repository.Apr 14 2021, 10:26 AM

Thanks for catching this :)
While at it, you can include the DamageTypes globalscript also.

While at it, you can include the DamageTypes globalscript also.

binaries/data/mods/public/globalscripts/DamageTypes.js ?
I did not find any translation lines there

Freagarach added a comment.EditedWed, Apr 14, 12:21 PM

Nah, there are no translation lines there, only a template_helpers that needs to be removed. (And that is needed for proper translation.)

nwtour updated this revision to Diff 17082.Wed, Apr 14, 12:25 PM

remove "template_helper" in DamageTypes.js

Freagarach accepted this revision.Wed, Apr 14, 12:26 PM
  • Correct.
  • Compleat.

Thanks for the patch!

This revision is now accepted and ready to land.Wed, Apr 14, 12:26 PM
This revision was automatically updated to reflect the committed changes.