• Works correctly when removing a civ-template.
• Works correctly when adding an aura to the generic "player"-template.

Edge case:
If you load up the civ overview (starting at athens) then move to Britons and add e.g. the Briton bonus to Athens and Carths, the bonus does show up when moving to Carth (was not present in the cache yet) but doesn't show for Athens (uses the cached data).

Apart from that, this works and I've not seen any (obvious) flaws in the code.

In D3864#167555, @Freagarach wrote:

Edge case:
If you load up the civ overview (starting at athens) then move to Britons and add e.g. the Briton bonus to Athens and Carths, the bonus does show up when moving to Carth (was not present in the cache yet) but doesn't show for Athens (uses the cached data).

You mean it's not hot-loading the player_{civ}.xml files? That's expected - simulation data files are not hot-loaded by the engine.

No, I mean that when you change civs the cached data is used although it may be outdated, e.g. if the file was changed. But I wouldn't call that blocking, just an edge case worth noting :)

Yeah... the JS environment has no way to tell if a file has been modified since it was last requested from the VFS. And considering that the VFS has its own caches - and hot-loading of simulation data files is not implemented - even when bypassing the JS-side cache the old file would still be loaded from the C++-side cache.

In D3864#167699, @s0600204 wrote:

And considering that the VFS has its own caches

Ah, thanks, I did not know that :)