Page MenuHomeWildfire Games

[Gameplay] Remove build limits of structures that train champions.
ClosedPublic

Authored by ValihrAnt on Apr 27 2021, 6:34 PM.

Details

Summary

Currently there are four different champions units, which are blocked from any realistic use by their production building being limited to just 1. This patch removes the limit. It also increases the resource trickle time of the Apadana and gives it a population cost of 5.

Test Plan

Check if the buildings have no limit. Make sure Apadanas aren't more efficient than trading.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ValihrAnt requested review of this revision.Apr 27 2021, 6:34 PM
ValihrAnt created this revision.
Stan added a subscriber: Stan.Apr 27 2021, 6:41 PM

You also need to edit the player files to remove that limit

You also need to edit the player files to remove that limit

That would be needed for multiplayer? In singleplayer I could put down as many of the buildings as my heart desired

Stan added a comment.Apr 27 2021, 6:48 PM

It works, but it means it's useless classes in those files.

ValihrAnt updated this revision to Diff 17251.Apr 27 2021, 6:58 PM

Removed now useless classes from player.xml file as per Stan

StarAtt added a subscriber: StarAtt.May 1 2021, 2:26 PM
ValihrAnt retitled this revision from Remove build limits of structures that train champions. to [Gameplay] Remove build limits of structures that train champions..May 3 2021, 10:06 AM
wraitii accepted this revision.May 24 2021, 3:38 PM
This revision is now accepted and ready to land.May 24 2021, 3:38 PM
Freagarach added inline comments.
binaries/data/mods/public/simulation/templates/structures/pers/apadana.xml
4 ↗(On Diff #17251)

I don't think population costs for structures work well currently.

marder added a subscriber: marder.EditedMay 25 2021, 8:15 AM

Very much in favor. Champions are expensive enough as is. No need to make their training more complicated.

Freagarach is correct, you can still place buildings and go over the pop limit. Which I wouldn't call a problem, but the apadana gives resources, so that's annoying.
I'll merge the patch except for the Apadana, which I'll limit to two instead of one. I think Persians aren't an infantry focused civ anyways, so this would probably be fine.

This revision was automatically updated to reflect the committed changes.
Owners added a subscriber: Restricted Owners Package.Jun 1 2021, 10:09 AM