Page MenuHomeWildfire Games

Move rating to the player tab
Needs ReviewPublic

Authored by Langbart on May 15 2021, 10:36 AM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

When you start a 1v1 MP game and uncheck the "Cheats" option on the "Player" tab, "Rating" is automatically enabled and you are forced to switch to the "Game Type" tab to change it.
This diff moves the "Rating" option to the "Player" tab.

Test Plan

Check if you see the option "Rating" in the player tab.

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 17271
Build 39834: arc lint + arc unit

Event Timeline

Langbart created this revision.May 15 2021, 10:36 AM
Owners added a subscriber: Restricted Owners Package.May 15 2021, 10:36 AM
Langbart requested review of this revision.May 15 2021, 10:36 AM

Can you also make it so that you can still toggle the other button? Having "no" is just not really convenient imo.

Langbart updated this revision to Diff 17593.EditedMay 16 2021, 4:18 PM
Langbart edited the test plan for this revision. (Show Details)

I couldn't figure out how to implement wraitti's request (Can you also make it so that you can still toggle the other button?). So I did the next best thing and made the rating permanently visible and also show "No" when "Cheats" are enabled.

Langbart updated this revision to Diff 17595.May 16 2021, 4:43 PM

The rating option is hidden if no rating option is available and the number of players is not equal to 2.