When you start a 1v1 MP game and uncheck the "Cheats" option on the "Player" tab, "Rating" is automatically enabled and you are forced to switch to the "Game Type" tab to change it.
This diff moves the "Rating" option to the "Player" tab.
Details
- Reviewers
- None
Check if you see the option "Rating" in the player tab.
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- /ps/trunk
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 17271 Build 39834: arc lint + arc unit
Event Timeline
Can you also make it so that you can still toggle the other button? Having "no" is just not really convenient imo.
I couldn't figure out how to implement wraitti's request (Can you also make it so that you can still toggle the other button?). So I did the next best thing and made the rating permanently visible and also show "No" when "Cheats" are enabled.
The rating option is hidden if no rating option is available and the number of players is not equal to 2.
I see the issue, but don't like this solution (since "rating" says more about game type than player), nor I have a better solution.
Surely when the gamesettingstabs were implemented there has been a discussion about this.
binaries/data/mods/public/gui/gamesetup/Pages/GameSetupPage/GameSettings/Single/Checkboxes/Rating.js | ||
---|---|---|
15 | Isn't that already in the gamesettings attribute, Ratings.js? (L21) | |
17 | Sounds like also done in the gamesettingsatribute already (hasXmppclient probably does it already) |