Fix and clean up cinematics
ClosedPublic
Actions

Authored by vladislavbelov on May 3 2017, 1:47 PM.

Details

Reviewers

elexis
• leper

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rP19533: Draw paths only when cinematics isn't playing. Patch by Vladislav.

Trac Tickets

#3814
#3871

Summary

Fixed the order of headers, noticed by @leper in rP19414
Removed redundant and useless headers
Draw paths only when the cinematics isn't playing
Fixed an issue, when GUI isn't shown after playing in atlas

Test Plan

Game:

Run the game
Open any map with cinema paths

Atlas:

Run the atlas
Open any map with cinema paths and play

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vladislavbelov created this revision.May 3 2017, 1:47 PM

Fixed EOLN.

Added ICmp.

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/974/ for more details.

Harbormaster completed remote builds in B1409: Diff 1609.May 3 2017, 6:02 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/975/ for more details.

Harbormaster completed remote builds in B1410: Diff 1610.May 3 2017, 6:48 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/976/ for more details.

Harbormaster completed remote builds in B1411: Diff 1611.May 3 2017, 7:35 PM

vladislavbelov edited the test plan for this revision. (Show Details)May 4 2017, 2:03 AM

• leper accepted this revision.May 8 2017, 5:58 AM

This revision is now accepted and ready to land.May 8 2017, 5:58 AM

Closed by commit rP19533: Draw paths only when cinematics isn't playing. Patch by Vladislav. (authored by • leper). · Explain WhyMay 8 2017, 6:02 AM

This revision was automatically updated to reflect the committed changes.