Page MenuHomeWildfire Games

Update the rank icons
Needs ReviewPublic

Authored by marder on Jun 8 2021, 1:57 PM.

Details

Reviewers
Langbart
Summary

Trying some variations for the rank icons, based on the ones that are already in SVN but are unused.

art/textures/ui/session/icons/ranks

Test Plan

You could apply the patch and check if the new icons look better than the old ones.

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17910
Build 41770: arc lint + arc unit

Event Timeline

Langbart created this revision.Jun 8 2021, 1:57 PM
Owners added a subscriber: Restricted Owners Package.Jun 8 2021, 1:57 PM
Langbart requested review of this revision.Jun 8 2021, 1:57 PM

These new icons don't stand out as well on certain backgrounds as the old ones did.

Langbart planned changes to this revision.Jun 8 2021, 2:22 PM
marder added a subscriber: marder.Jun 8 2021, 2:49 PM

@Langbart
Try these ones

marder added a comment.Jun 8 2021, 3:28 PM

new ones:


Langbart updated this revision to Diff 18133.Jun 8 2021, 3:36 PM
Langbart retitled this revision from Update the rank icons to Update the rank icons.

Added new icons from @marder and renamed the old icons instead of deleting them.

marder added a comment.Jun 8 2021, 3:58 PM

here the 32x32 version


marder added a comment.EditedJun 8 2021, 4:04 PM

for some reason the 64 version still looks better, but I think the 32 version is stil an improvement.

Langbart updated this revision to Diff 18134.Jun 8 2021, 4:05 PM

Update icons

Langbart edited the summary of this revision. (Show Details)Jun 8 2021, 4:24 PM
marder added a comment.EditedJun 9 2021, 8:32 PM

Update here, to not litter the comments with icons

Stan added a subscriber: Stan.Jun 9 2021, 10:26 PM

Drop shadow is a bit strange but seems to work better ?

actually not sure if it is better after all.
Closeup definite yes


Far away not good:

I think that would be mitigated by adding mipmaps. Add this file in the ranks folder:

(though this will only work well for icons that are used in the 3D scene, not for GUI icons).

I honestly think the old ones look better. :)

I think that would be mitigated by adding mipmaps. Add this file in the ranks folder:

(though this will only work well for icons that are used in the 3D scene, not for GUI icons).

It does make it better, although it is still hard to see.

marder commandeered this revision.Jun 10 2021, 7:41 PM
marder added a reviewer: Langbart.
marder edited the summary of this revision. (Show Details)