Those maps are made for debugging purposes, should not be translated, and should not be bundled in release
Details
- Reviewers
Stan - Group Reviewers
Restricted Owners Package (Owns No Changed Paths)
Suggest improvements
Check for completeness
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- /ps/trunk
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 17908 Build 41765: Vulcan Build Jenkins Build 41764: Vulcan Build (macOS) Jenkins Build 41763: Vulcan Build (Windows) Jenkins Build 41762: arc lint + arc unit
Event Timeline
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/6344/display/redirect
Successful build - Chance fights ever on the side of the prudent.
Debug: Microsoft (R) Build Engine version 15.9.21+g9802d43bc3 for .NET Framework Copyright (C) Microsoft Corporation. All rights reserved. Release: Microsoft (R) Build Engine version 15.9.21+g9802d43bc3 for .NET Framework Copyright (C) Microsoft Corporation. All rights reserved.
Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/5721/display/redirect
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/macos-differential/4626/display/redirect
Don't understand why these should not be in a release and hence not why they shouldn't be translated. It doesn't seem to add that many strings anyhow and in any case those strings are relatively easy to translate. Someone without svn might just as well want to try some stuff and/or search bugs in game. And they are hidden under the demo filter anyhow.
Voting for abandonment.
The quality of those maps isn't always great, some are totally unplayable or are unfinished.
I agree with @bb, a modder may find them useful to e.g. test template values and check whether dancing is still present. Also, not all of the game is of the same quality, so should we remove all that?
Well that's the eternal debate I have with @vladislavbelov over quantity vs quality.
Note that in this case we are not removing them just putting them in another mod that can totally be put on mod.io.
To explain why I would remove them (and possibly also other maps):
There are so many maps in the game that it gets hard to navigate. Imo the release should just include the best / prettiest/ most fun to play maps and they should be easy to select and find.
If a new user wants to play a match for the first time they will be overwhelmed by the options and filters and chances are they may choose a map which is subpar and not representative of the quality the game can offer.
So I would remove all the maps that don't meet the expectations a player has (i.e nice to play, nice graphics) and then put them as @Stan said in an extra mod, for everyone who is interested.
[Edit] - to clarify: here is a general related forum thread discussing maps:
https://wildfiregames.com/forum/topic/28521-completed-terrain-and-map-overhaul-milestone-alpha-25/?do=findComment&comment=425969
and my personal rating of the (Skirmish) maps we have:
https://wildfiregames.com/forum/topic/28521-completed-terrain-and-map-overhaul-milestone-alpha-25/?do=findComment&comment=430749
It seems like Stan is only moving the demo maps. Which isn't super useful IMO, since those are already hidden by the 'demo' tag. Moving lower-quality maps is a different topic, which IIRC was discussed as 'community maps' but the naming really isn't that good.
I don't really have much opinion but a specific mod just for test maps doesn't seem that useful, beyond possibly maps needed for C++ tests (possibly a different issue).
Some 'test' maps are certainly useful for mods. But it can be argued that those should use the development version.
I removed two broken maps. Not also that I didn't remove the sandbox maps which are in demo, and could be fun to play for some people. And are definitely hidden by the number of demo maps that aren't really playable. Most of the demo maps don't have map previews either.
If the game is to be healthy going forward, some things need trimmed. Extraneous maps are 1 very easy area to do this.