These were either pointed out by GCC6, cppcheck, or Clang's scan-build.
Dunno which one, maybe the second.
Details
Details
- Reviewers
vladislavbelov - Group Reviewers
Restricted Owners Package (Owns No Changed Paths)
Check that there isn't some wxWidgets magic going on that takes ownership of those and does the cleanup.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- warning_fixes
- Lint
Lint Skipped - Unit
Unit Tests Skipped - Build Status
Buildable 1426 Build 2249: Vulcan Build Jenkins Build 2248: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
http://jw:8080/job/phabricator/990/ for more details.
Comment Actions
Deleting of undefined pointer is UB, I think. So see the inline comment.
| source/tools/atlas/AtlasUI/ScenarioEditor/SectionLayout.cpp | ||
|---|---|---|
| 250 | Add: SectionLayout::SectionLayout() : m_HorizSplitter(nullptr), m_VertSplitter(nullptr), m_SidebarBook(nullptr) { } | |
Comment Actions
Actually all those created objects inherit from some wxThing, so the parent of those is responsible for cleaning this up. I knew I should have checked that again before submitting this, ah well.