Differential D4194

Tutorial in Learn to Play menu refer to Introductory Tutorial
ClosedPublic
Actions

Authored by azayrahmad on Jul 18 2021, 1:38 PM.

Details

Reviewers

wraitii

Commits

rP26702: Use the Introductory Tutorial as tutorial.

Trac Tickets

#6347

Summary

In Main Menu, the Learn to Play > Tutorial menu leads to Starting Economy Walkthrough, instead of the more beginner-friendly Introductory Tutorial.

Warning: The menu description use translation, so the translation for this description would have to be retranslated.

Test Plan

Select Learn to Play
Select Tutorial
Confirm that Introductory Tutorial is loaded.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Lint Skipped

Unit

Unit Tests Skipped

Event Timeline

azayrahmad requested review of this revision.Jul 18 2021, 1:38 PM

azayrahmad created this revision.

azayrahmad edited the summary of this revision. (Show Details)Jul 19 2021, 2:11 AM

bb added a subscriber: bb.Aug 28 2021, 1:51 PM

bb added inline comments.

binaries/data/mods/public/gui/pregame/MainMenuItems.js
17	I guess it would even be better to change to the relevant campaign page, instead of autostarting whatever map.

... and provide context to your patch.

svn diff --diff-cmd diff -x "-U 99999" > changes.patch

wiki/SubmittingPatches

Langbart updated the Trac tickets for this revision.Oct 4 2021, 5:54 PM

@Freagarach @bb is the proposed fix acceptable for FF?

Fine for me. I'll try to commit this this week, unless objected.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 25 2022, 7:26 AM

Closed by commit rP26702: Use the Introductory Tutorial as tutorial. (authored by Freagarach). · Explain Why

This revision was automatically updated to reflect the committed changes.

Freagarach added a commit: rP26702: Use the Introductory Tutorial as tutorial..

Owners added a subscriber: Restricted Owners Package.Mar 25 2022, 7:26 AM

Revision Contents
Changeset List

Path

Size

binaries/

data/

mods/

public/

gui/

pregame/

	MainMenuItems.js
	MainMenuItems.js (revision 25825)

4 lines

Diff 18318

View Options

binaries/data/mods/public/gui/pregame/MainMenuItems.js

Tutorial in Learn to Play menu refer to Introductory TutorialClosedPublicActions