Page MenuHomeWildfire Games

Fix possible null dereferences.
ClosedPublic

Authored by leper on May 4 2017, 1:33 AM.

Details

Reviewers
vladislavbelov
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP19532: Fix possible null dereferences.
Summary

Pointed out by either cppcheck or scan-build (I think the former, since the latter wouldn't build this on my box).

Test Plan

Think hard about what would happen if one of those was null and the other wasn't.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

leper created this revision.May 4 2017, 1:33 AM
Vulcan added a subscriber: Vulcan.May 4 2017, 11:20 AM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/991/ for more details.

vladislavbelov accepted this revision.May 4 2017, 12:03 PM
vladislavbelov added a subscriber: vladislavbelov.

Looks good.

This revision is now accepted and ready to land.May 4 2017, 12:03 PM
This revision was automatically updated to reflect the committed changes.