Page MenuHomeWildfire Games

Remove broken atlas error reporting code.
ClosedPublic

Authored by leper on May 4 2017, 2:58 AM.

Details

Reviewers
fatherbushido
vladislavbelov
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP19511: Remove broken atlas error reporting code.
Summary

This has been disabled for nearly 10 years (r5034), so remove it.

Test Plan

Check that it still compiles.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

leper created this revision.May 4 2017, 2:58 AM

It seems there is also 2 occurences in source/tools/atlas/GameInterface/GameLoop.cpp

leper updated this revision to Diff 1639.May 4 2017, 10:43 AM

Remove mentions in the DLL loading code, that might have even caused this to not work if tried.

fatherbushido accepted this revision.EditedMay 4 2017, 10:54 AM

Compilation ok on "Linux debian 4.9.0-2-amd64 #1 SMP Debian 4.9.18-1 (2017-03-30) x86_64 GNU/Linux"

This revision is now accepted and ready to land.May 4 2017, 10:54 AM
vladislavbelov accepted this revision.May 4 2017, 11:21 AM
vladislavbelov added a subscriber: vladislavbelov.

It compiles & works on Windows.

This revision was automatically updated to reflect the committed changes.
Vulcan added a subscriber: Vulcan.May 4 2017, 6:04 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/996/ for more details.

Vulcan added a comment.May 4 2017, 8:26 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/999/ for more details.