Page MenuHomeWildfire Games

D13 post-quisite 12: remove speed change when fleeing
AbandonedPublic

Authored by wraitii on May 7 2017, 11:06 AM.

Details

Reviewers
None
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Summary

This isn't per-se related to UnitMotion, but I've always found this ridiculous so I'm motioning to get it removed.

Fleeing units have no reason whatsoever to go faster than their natural moving speed in this game.

Test Plan

Attack an animal and a woman.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 1510
Build 2385: Vulcan BuildJenkins

Event Timeline

wraitii created this revision.May 7 2017, 11:06 AM
fatherbushido added a subscriber: fatherbushido.EditedMay 7 2017, 11:33 AM

I don't know what's the other devs opinion but I think also it seems useless complexity and removing that will (not solve but at least) reduce some weird attack effects.
(On the other side, what run speed will be used for?)

Run Speed could be used for group-walking (but not necessarily a fan of that) or possibly for animal attacking, which is a slightly different thing. Otherwise the engine needs to support reduced speed, so the feature needs some level of support anyways.

elexis added a subscriber: elexis.May 7 2017, 12:31 PM

Why do we keep run speed if we don't find it more appealing than Walk speed in case of fleeing?

@elexis: ?? That's what this diff is changing?

elexis added a comment.May 7 2017, 1:40 PM

Yes, RunSpeed is kept because it isn't removed entirely, still contained in the templates and used for formations. If it looks ridiculuous when fleeing, doesn't it also look ridiculous when changing the formation?

Well I personally think it does, but the feature could be useful in the future, via triggers, and it could be useful for animals as I've said above, so I don't necessarily plan to remove it entirely.

Vulcan added a subscriber: Vulcan.May 7 2017, 4:21 PM

Build has FAILED

Link to build: http://jw:8080/job/phabricator/1053/
See console output for more information: http://jw:8080/job/phabricator/1053/console

wraitii abandoned this revision.May 25 2019, 10:53 AM

won'tdo