Removed the word "Aura" at the end of Aura names at the suggestion of @fatherbushido
Created new names for auras that only had "Hero Aura"
Rewritten some names to make them more impressive/correct with the removal of "Aura"
Details
- Reviewers
fatherbushido elexis
Open Structure Tree and see new aura names.
Check for possible typos.
Check for correctness and historical foundation.
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Lint Skipped - Unit
Unit Tests Skipped - Build Status
Buildable 1526 Build 2408: Vulcan Build Jenkins
Event Timeline
Nice job!
Perhaps a better name for the Garrisoned one, else it's really nice.
If nobody have comments, I will commit it.
binaries/data/mods/public/simulation/data/auras/units/heroes/hero_garrison.json | ||
---|---|---|
7 | That one could be improved perhaps |
Agree with fatherbushido, good work Hannibal.
binaries/data/mods/public/simulation/data/auras/structures/epic_temple_heal.json | ||
---|---|---|
8 | not sure about capitalizaiton of god. If the entire thing is a name, shouldn't Of and The also be capitalized? | |
binaries/data/mods/public/simulation/data/auras/structures/iber_monument.json | ||
13 | Still can't find anything on the web what a Gur Oroigarri is, but the aura title fits to the History string in the XML: Also someone posted in #0ad-dev few days ago that the iberian monument was apparntly confused with something chines iirc, but I can't find it in the logs. | |
binaries/data/mods/public/simulation/data/auras/structures/library.json | ||
12 | Apparently prepositions are not capitalized, even in names, at least from what I could find in the first 10min. | |
binaries/data/mods/public/simulation/data/auras/units/heroes/gaul_hero_brennus.json | ||
7 | (I thought we had this name for a catafalque already, but apparently not) | |
binaries/data/mods/public/simulation/data/auras/units/heroes/hero_garrison.json | ||
7 | Something about resistance or perseverance? |
Build has FAILED
Link to build: http://jw:8080/job/phabricator/1059/
See console output for more information: http://jw:8080/job/phabricator/1059/console
Build has FAILED
Link to build: http://jw:8080/job/phabricator/1062/
See console output for more information: http://jw:8080/job/phabricator/1062/console