Paths

Table of Contentst

Differential D4494

Clean PlayerManager.js.
ClosedPublic
Actions

Authored by Freagarach on Feb 18 2022, 10:16 AM.

Details

Reviewers

None

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rP26477: Clean PlayerManager.js.

Summary

Remove obseleted function RemoveAllPlayers in rP16080.
Linter stuff.
Don't initialise undefined world population value.

Test Plan

Check that stuff works:

Atlas.
- Add/Remove players.
Autostart.
Normal matches.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Freagarach created this revision.Feb 18 2022, 10:16 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/6778/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/5686/display/redirect

Harbormaster completed remote builds in B19528: Diff 19702.Feb 18 2022, 10:32 AM

Freagarach requested review of this revision.Feb 18 2022, 10:32 AM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 24 2022, 8:04 AM

This revision was landed with ongoing or failed builds.

Closed by commit rP26477: Clean PlayerManager.js. (authored by Freagarach). · Explain Why

This revision was automatically updated to reflect the committed changes.

Freagarach added a commit: rP26477: Clean PlayerManager.js..

Revision Contents
Changeset List

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

simulation/

components/

Player.js

8 lines

PlayerManager.js

94 lines

Diff 19748

View Options

ps/trunk/binaries/data/mods/public/simulation/components/Player.js