Differential D4495

Fix landscape settings for unknown map
ClosedPublic
Actions

Authored by marder on Feb 18 2022, 4:23 PM.

Details

Reviewers

Silier

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rP26437: Fix landscape settings for unknown map

Summary

As reported here: https://wildfiregames.com/forum/topic/51306-thread-for-posting-suggestions-for-alpha-26/page/13/#comment-479133
by BreakfastBurrito_007

One setting of the landscape options was mislabeled and therefore did not create a shallow river, but a normal deep river.

Test Plan

test unknown with the landscape option 'Central River' and see if it is passable or not.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marder created this revision.Feb 18 2022, 4:23 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/6781/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/5689/display/redirect

Harbormaster completed remote builds in B19531: Diff 19705.Feb 18 2022, 4:38 PM

marder requested review of this revision.Feb 18 2022, 4:38 PM

so this is fixing issue in D4457 correct?

In D4495#192000, @Silier wrote:

so this is fixing issue in D4457 correct?

No, different issue, just the same map.

The problem here is about the 'Central River' being too deep, despite it being a land map.
D4457 is about not being able to reach the opponent on 'Passes' + there sometimes being a lake, which turns the land map into a naval map as well

Looks okay

This revision is now accepted and ready to land.Feb 19 2022, 12:13 PM

This revision was landed with ongoing or failed builds.Feb 20 2022, 8:30 AM

Closed by commit rP26437: Fix landscape settings for unknown map (authored by Silier). · Explain Why

This revision was automatically updated to reflect the committed changes.

Silier added a commit: rP26437: Fix landscape settings for unknown map.

Thank you for the patch

Revision Contents
Changeset List

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

maps/

random/

unknown.json

2 lines

Diff 19715

View Options

ps/trunk/binaries/data/mods/public/maps/random/unknown.json

Fix landscape settings for unknown mapClosedPublicActions