Page MenuHomeWildfire Games

Add feldmap (balanced Mainland) to 0AD
Needs ReviewPublic

Authored by Kate on Feb 21 2022, 10:52 PM.

Details

Reviewers
None
Group Reviewers
Balancing
Restricted Owners Package(Owns No Changed Paths)
Summary

adds the new maps
adds the better map generation algorithms

[Edit] Link to forum discussion: https://wildfiregames.com/forum/topic/71678-commit-feldmap-to-a26/

Test Plan

has been tested

Event Timeline

Kate created this revision.Feb 21 2022, 10:52 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/6795/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/5703/display/redirect

Kate requested review of this revision.Feb 21 2022, 11:08 PM

few things to note:
normally it is better if the author of maps and patches upload them themselves, be it to fix bugs and change stuff or just to show that they actually hold the rights about the code and are ok with it being uploaded and made open source.

Also @Feldfeld already uploaded alpine mountains D2830 and a patch for more balanced resources D4232 (which no one had the time to review until now)

Finally, this patch would duplicate basically all the generic biomes which is unnecessary? and / or more reason for D4451 if there is a difference.

marder added a comment.EditedFeb 22 2022, 7:12 AM

I would lean towards abandoning this in favor of the general D4232 (which I plan to take a look at / review).

Or as I said in the forums: Just replacing mainland with the balanced version and include the function for that in the rm script. And then long term replace that by D4232 or something more general.

@Feldfeld whats your opinion?

marder edited the summary of this revision. (Show Details)Feb 22 2022, 7:28 AM
marder added a reviewer: Restricted Owners Package.

Of course if there is a new patch to add mainland balanced, it would have to be much smaller and include only that map.
The reason biomes were duplicated was so I could remove the Jungle biome, IIRC it was quite laggy, but of course that would not be something I do if Mainland Balanced gets included in the game.

Or as I said in the forums: Just replacing mainland with the balanced version and include the function for that in the rm script. And then long term replace that by D4232 or something more general.

@Feldfeld whats your opinion?

I answered it in forum, personally I'm fine with anything.