Page MenuHomeWildfire Games

Fix autostart MP mode and enable cheats in autostarted games
ClosedPublic

Authored by elexis on May 8 2017, 5:38 AM.

Details

Summary

It should be possible to use the existing cheats in autostarted games.
But for the following reasons, it is not needed to add a command line option and just enabling them always is needed:

  1. For consistency with gamesetup.js, as this page always enables cheats in SP
  2. Since the autostart multiplayer gamemode has never implemented player assignments and must have relied on the change-perspective developer feature

to control players from the observermode, which was restricted to cheats being enabled as of rP17170.

In rP17288 the non-temporary fix rP17282 was reverted because cheating in autostarted SP mode was expected but not available.

While at it, fix that example map which doesn't exist since numerous years.

Test Plan

Start an SP game from command line and enter a cheat like "gift from the gods" (see the command from the readme or cpp file).
Start an MP game from command line and change the perspective to a player (notice that autostart MP mode without the patch only allows observing).

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

elexis created this revision.May 8 2017, 5:38 AM
Vulcan added a subscriber: Vulcan.May 8 2017, 7:25 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/1081/ for more details.

echotangoecho accepted this revision.May 12 2017, 12:26 AM
This revision is now accepted and ready to land.May 12 2017, 12:26 AM

Thanks for the review / testing.

This revision was automatically updated to reflect the committed changes.