Page MenuHomeWildfire Games

Fixes depth texture sampling in ARB shaders after rP26485
ClosedPublic

Authored by vladislavbelov on May 9 2022, 1:08 AM.

Details

Reviewers
None
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP26862: Fixes depth texture sampling in ARB shaders after rP26485. Fixes #6537
Trac Tickets
#6537
Summary

The rP26485 disabled the FFP depth texture mode. In ARB shaders TEX command uses the first argument as the source and destination channel. Without INTENSITY mode the alpha channel returns a constant value.

Test Plan
  1. Apply the patch
  2. Run the game with GL ARB backend
  3. Check shadows

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vladislavbelov created this revision.May 9 2022, 1:08 AM
Vulcan added a comment.May 9 2022, 1:10 AM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/6013/display/redirect

Vulcan added a comment.May 9 2022, 1:14 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/7104/display/redirect

Vulcan added a comment.May 9 2022, 1:24 AM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/7710/display/redirect

vladislavbelov requested review of this revision.May 9 2022, 1:24 AM

Arcanist wouldn't let me apply the patch, but doing it manually did the trick.
Patch fixes the problem described in the ticket.

This revision was not accepted when it landed; it landed in state Needs Review.May 9 2022, 9:55 AM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.