Page MenuHomeWildfire Games

Tooltip on End of game summary charts, showing the y-value of the graphs for each player.
Needs ReviewPublic

Authored by thehiggsfield on May 24 2022, 6:30 PM.
This revision needs review, but there are no reviewers specified.



"Add a Tooltip to the end of game summary charts, which displays eachs player's collor indicator followed by the displayed y-value of the graph for that player, at the time the mouse is hovering over."

Test Plan

"I opend the Summary screen from the Replays menu, during a game and after a game. For each of these I moused over the two charts with Score/Total score, Miscellaneous/Kill-Death and Miscellaneous/Feminization selected (since they each have one of the 3 different y-vlaue types). I then confirmed the look of the tooltip with "Group by team" on and off.

Diff Detail

rP 0 A.D. Public Repository
Lint OK
No Unit Test Coverage
Build Status
Buildable 20379
Build 49063: arc lint + arc unit

Event Timeline

thehiggsfield created this revision.May 24 2022, 6:30 PM
Owners added a subscriber: Restricted Owners Package.May 24 2022, 6:30 PM
thehiggsfield requested review of this revision.May 24 2022, 6:30 PM

Hey, I just wanted to add a comment.
I have a decent amount of coding experience (not with JavaScript though), but I have never participated in large scale coding collaborations. Therefore I would greatly appreciate any feedback on this revision, especially if I have committed any big no-nos, so I can learn how to better contribute moving forwards.

Both thanks and apologies in advance.

no need to apologize :)
congrats on your first patch!

The only real problem is that there are not that many people around who work on the gui -> so it might take quite a while to get good feedback.

and I can't really say anything about this specific patch as I tend to never look at the summary screen and therefore have no opinion on if this is something the would be cool to have or not.