Page MenuHomeWildfire Games

Remove redundant references to deleted .dtd files
AbandonedPublic

Authored by Langbart on Tue, Aug 2, 5:51 AM.

Details

Reviewers
Stan
Trac Tickets
#5556
Summary
issue

The check with xmllint fails during validation. See log output below for more clarity

terminal
❯ xmllint '/Users/paria/0ad/binaries/data/mods/public/gui/common/global.xml' --relaxng '/Users/paria/0ad/binaries/data/mods/mod/gui/gui.rng' --noout
/Users/paria/0ad/binaries/data/mods/public/gui/common/global.xml:3: warning: failed to load external entity "/Users/paria/0ad/binaries/data/mods/public/gui/gui.dtd"
<!DOCTYPE objects SYSTEM "../gui.dtd">
                                      ^
/Users/paria/0ad/binaries/data/mods/public/gui/common/global.xml validates
solution

Remove redundant references to deleted .dtd (Document Type Definition) files.

A DTD defines the structure and the legal elements and attributes of an XML document.

Source: w3schools.com

The problem is partially mentioned in #5556.

Test Plan

Testing with xmllint should work.

Event Timeline

Langbart created this revision.Tue, Aug 2, 5:51 AM
Owners added subscribers: Restricted Owners Package, Restricted Owners Package, Restricted Owners Package.Tue, Aug 2, 5:51 AM
Vulcan added a comment.Tue, Aug 2, 5:56 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/7374/display/redirect

Vulcan added a comment.Tue, Aug 2, 6:07 AM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/6284/display/redirect

Langbart requested review of this revision.Tue, Aug 2, 6:20 AM
Langbart edited the summary of this revision. (Show Details)Tue, Aug 2, 6:30 AM
Langbart edited the test plan for this revision. (Show Details)
Stan added a subscriber: Stan.Tue, Aug 2, 11:13 AM

I'm not sure about the last one since it's an external lib. Otherwise looks good. I wonder if DTDs give more useful messages than RNG.

Langbart updated this revision to Diff 20694.Tue, Aug 2, 12:39 PM
Langbart retitled this revision from Remove redundant references to deleted .dtd files to Remove redundant references to deleted .dtd files.

Restore catalog.xml

Stan accepted this revision.Tue, Aug 2, 12:42 PM

LGTM.

This revision is now accepted and ready to land.Tue, Aug 2, 12:42 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/7375/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/6285/display/redirect

Langbart abandoned this revision.Sat, Aug 6, 7:37 PM