Differential D4792

Allow 0.0.0.0 IP in StunClient tests
ClosedPublic
Actions

Authored by kalev on Oct 1 2022, 12:59 PM.

Details

Reviewers

vladislavbelov

Commits

rP27164: Allow 0.0.0.0 IP in StunClient tests added in rP25448.

Summary

Fix an off-by-one to allow 0.0.0.0.

This fixes the test to pass in Fedora's mock chroot.

Test Plan

I applied the patch to Fedora's 0ad package and verified that it builds in mock. Before applying the patch it failed with:

In TestStunClient::test_local_ip:
/builddir/build/BUILD/0ad-0.0.26-alpha/source/network/tests/test_StunClient.h:47: Error: Test failed: StunClient::FindLocalIP did not return a valid IPV4 address: wrong size

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kalev requested review of this revision.Oct 1 2022, 12:59 PM

kalev created this revision.

Uploaded a new diff with more context and added myself to programming.json.

LGTM. Will be commited after end of FF.

This revision is now accepted and ready to land.Oct 1 2022, 2:54 PM

Closed by commit rP27164: Allow 0.0.0.0 IP in StunClient tests added in rP25448. (authored by vladislavbelov). · Explain WhyOct 22 2022, 9:22 PM

This revision was automatically updated to reflect the committed changes.

vladislavbelov added a commit: rP27164: Allow 0.0.0.0 IP in StunClient tests added in rP25448..

Owners added a subscriber: Restricted Owners Package.Oct 22 2022, 9:22 PM

Revision Contents
Changeset List

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

gui/

credits/

texts/

programming.json

1 line

source/

network/

tests/

test_StunClient.h

4 lines

Diff 20990

View Options

ps/trunk/binaries/data/mods/public/gui/credits/texts/programming.json