Page MenuHomeWildfire Games

source/lib/sysdep/compiler.h: Updated ifdef condition for MCST-LCC compiler
ClosedPublic

Authored by r-a-sattarov on Oct 2 2022, 3:08 PM.

Details

Summary

Since version 1.25, a new macro __MCST__ has been added to the MCST LCC compiler, which uniquely identifies this compiler. Therefore, the previous way of defining a compiler should be modified.

A similar patch has already been accepted in other projects, such as curl

Test Plan

Code reviews, other pitfalls.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

r-a-sattarov created this revision.Oct 2 2022, 3:08 PM
r-a-sattarov edited the summary of this revision. (Show Details)
Vulcan added a comment.Oct 2 2022, 3:23 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/6404/display/redirect

Vulcan added a comment.Oct 2 2022, 3:29 PM

Successful build - Chance fights ever on the side of the prudent.

Debug:
     8>tinygettext.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vs2017\tinygettext.vcxproj]
    17>wsecure_crt.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vs2017\lowlevel.vcxproj]
    17>wprofiler.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vs2017\lowlevel.vcxproj]
    17>manifest.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vs2017\lowlevel.vcxproj]
    17>secure_crt.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vs2017\lowlevel.vcxproj]
    17>posix.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vs2017\lowlevel.vcxproj]
    17>vfs_path.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vs2017\lowlevel.vcxproj]
    17>file_stats.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vs2017\lowlevel.vcxproj]

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/7496/display/redirect

r-a-sattarov published this revision for review.Oct 7 2022, 12:18 AM
Stan accepted this revision.Oct 7 2022, 9:42 AM
This revision is now accepted and ready to land.Oct 7 2022, 9:42 AM
This revision was landed with ongoing or failed builds.Oct 7 2022, 9:45 AM
This revision was automatically updated to reflect the committed changes.