Page MenuHomeWildfire Games

Macedonian team bonus
ClosedPublic

Authored by fatherbushido on May 12 2017, 12:14 PM.

Details

Reviewers
mimo
Summary

Needs D478

Test Plan

-

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 1824
Build 2891: Vulcan BuildJenkins
Build 2890: arc lint + arc unit

Event Timeline

fatherbushido created this revision.May 12 2017, 12:14 PM
Vulcan added a subscriber: Vulcan.May 12 2017, 2:59 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/1161/ for more details.

use sell instead of buy

remove unrelated changes

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/1179/ for more details.

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/1180/ for more details.

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/1259/ for more details.

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/1262/ for more details.

mimo edited edge metadata.May 20 2017, 9:55 AM

Patch is fine, but i wonder if well balanced compared to other team bonuses. Maybe increase it to 1.15 or 1.20?

In D480#21116, @mimo wrote:

Patch is fine, but i wonder if well balanced compared to other team bonuses. Maybe increase it to 1.15 or 1.20?

sure, 1.20 sounds good

tweak balance

mimo accepted this revision.May 20 2017, 6:54 PM
mimo added inline comments.
binaries/data/mods/public/simulation/data/auras/teambonuses/mace_player_teambonus.json
12

tooltip should be changed too

This revision is now accepted and ready to land.May 20 2017, 6:54 PM

fix tooltip

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/1269/ for more details.

Build has FAILED

Link to build: http://jw:8080/job/phabricator/1271/
See console output for more information: http://jw:8080/job/phabricator/1271/console