When selecting a map that disables the ptolemian lighthouse, that setting will be saved to g_GameAttributes.
If another map is selected afterwards, the property is persisted (since all properties are persisted if not deleted explicitly at the moment).
This means the lighthouse will be unavailable if having selecting a map before that disables it, even if the current map doesn't disable it.
This has been annoying many players, so I propose to add this property to the whitelist for Alpha 22 until we have rewritten this gamesetup yet again.
Details
Details
- Open the gamesetup and select the maptype "random"
- Select the map "belgian uplands" (which disables the lighthouse)
- Press F9 and type warn(uneval(g_GameAttributes.settings.DisabledTemplates)) and notice the lighthouse is disabled
- Select another map that doesn't disable it, like cosrica vs. sardinia
- Press F9 again, press the "up" arrow key and notice the lighthouse is still disabled if not having applied this patch
- Start the game to see that it is in fact disabled without this patch
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
http://jw:8080/job/phabricator/1183/ for more details.