Differential D4894

Don't build premake uselessly
Needs ReviewPublic
Actions

Authored by Stan on Jan 16 2023, 4:07 PM.

Details

Reviewers: None

Summary

Subj.

Test Plan

Test that premake isn't built each time you run update-workspaces.sh like the other ones.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 21478
Build 52081: Vulcan Build	Jenkins
Build 52080: Vulcan Build (macOS)	Jenkins
Build 52079: Vulcan Build (Windows)	Jenkins

Event Timeline

Stan created this revision.Jan 16 2023, 4:07 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/8377/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/7796/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/6704/display/redirect

Harbormaster completed remote builds in B21478: Diff 21384.Jan 16 2023, 4:40 PM

Stan requested review of this revision.Jan 16 2023, 4:40 PM

sera added a subscriber: sera.Jan 16 2023, 7:22 PM

sera added inline comments.

build/premake/build.sh
3	could you use the actual premake upstream version + wfg version

Stan added inline comments.Jan 16 2023, 7:26 PM

build/premake/build.sh
3	Yeah was just a test. See discussion on IRC about the whole thing possibly being overkill :)

Revision Contents
Changeset List

Path

Size

build/

premake/

build.sh

34 lines

workspaces/

update-workspaces.sh

21 lines

Diff 21384

View Options

build/premake/build.sh