Page MenuHomeWildfire Games

Allow setting tags to templates.
AbandonedPublic

Authored by Freagarach on Feb 3 2023, 4:05 PM.
Tags
None
Subscribers
Restricted Owners Package
Restricted Owners Package
Restricted Owners Package
Restricted Owners Package

Details

Reviewers
None
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Summary

Alternative to D4887, refs. rP26298.

Test Plan

Play some games, test Atlas.

Event Timeline

Freagarach created this revision.Feb 3 2023, 4:05 PM
Owners added subscribers: Restricted Owners Package, Restricted Owners Package, Restricted Owners Package, Restricted Owners Package.Feb 3 2023, 4:05 PM
Vulcan added a comment.Feb 3 2023, 4:06 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/8465/display/redirect

Vulcan added a comment.Feb 3 2023, 4:06 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/6792/display/redirect

Freagarach published this revision for review.Feb 6 2023, 10:28 AM

(Fails to apply due to the moving of files.)

Stan added a subscriber: Stan.Feb 6 2023, 10:38 AM
Stan added inline comments.
source/ps/TemplateLoader.cpp
96

I know you love old english :)

97–101

Can't we remove those hardcodings by using types?

source/simulation2/components/CCmpTemplateManager.cpp
227

Do we need to check if type exists?

Freagarach marked an inline comment as done.Feb 6 2023, 10:59 AM
Freagarach added inline comments.
source/ps/TemplateLoader.cpp
97–101

With the former, you'd need to add the type to every template that can be used -> cumbersome, but possible.
For the latter kind of the same as the former. Mixins should get a separate type than, but every template that uses the mixin should reset the type.

source/simulation2/components/CCmpTemplateManager.cpp
227

GetChild returns the nullnode when the child isn't there, which can be called ToString as well. So I don't think we need it.

Stan added a comment.Feb 15 2023, 9:21 AM

Wondered today if we could not have a second attribute for visibleinatlas="false" or abstract="true"

But it's still inherited so it's annoying.

Freagarach abandoned this revision.Feb 27 2023, 12:40 PM
Freagarach marked an inline comment as done and an inline comment as not done.