Details
- Reviewers
- None
- Group Reviewers
Restricted Owners Package (Owns No Changed Paths)
Play some games, test Atlas.
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- /ps/trunk
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 21613 Build 52475: Vulcan Build Jenkins Build 52474: Vulcan Build (macOS) Jenkins Build 52473: Vulcan Build (Windows) Build 52472: arc lint + arc unit
Event Timeline
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/8465/display/redirect
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/macos-differential/6792/display/redirect
source/ps/TemplateLoader.cpp | ||
---|---|---|
97–101 | With the former, you'd need to add the type to every template that can be used -> cumbersome, but possible. | |
source/simulation2/components/CCmpTemplateManager.cpp | ||
227 | GetChild returns the nullnode when the child isn't there, which can be called ToString as well. So I don't think we need it. |
Wondered today if we could not have a second attribute for visibleinatlas="false" or abstract="true"
But it's still inherited so it's annoying.