Page MenuHomeWildfire Games

Show replay directory name in the replay menu
ClosedPublic

Authored by elexis on May 14 2017, 4:54 AM.

Details

Summary

Every time players want to share a replay, they need to figure out the filename.
This is shown only when deleting, so only few know about this way to find the filename and if it's known it could happen to unintentionally delete the replay.
Unconditionally showing the filename will avoid any question, but might be considered verbose.

Test Plan

Not much really. Should we move that line below the the buttons instead?

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

elexis created this revision.May 14 2017, 4:54 AM
elexis edited the summary of this revision. (Show Details)May 14 2017, 4:56 AM
Sandarac requested changes to this revision.May 14 2017, 5:17 AM
Sandarac added a subscriber: Sandarac.

While at it, the replay filename should become copyable.

(I think keeping it above the buttons is okay.)

This revision now requires changes to proceed.May 14 2017, 5:17 AM
elexis requested review of this revision.May 14 2017, 5:19 AM
elexis edited edge metadata.

Is it a must have? because read-only input text fields are not implemented yet and I don't see me having time for this in the next 2 weeks

In D495#19828, @elexis wrote:

Is it a must have? because read-only input text fields are not implemented yet and I don't see me having time for this in the next 2 weeks

No, but it would make sense to allow players to copy that string if it's going to be displayed like that in the replay menu.

Vulcan added a subscriber: Vulcan.May 14 2017, 7:17 AM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/1192/ for more details.

Actually read-only input fields are planned with #4225

An alternative

would show it below the buttons, but not convinced of that as it looks weird with the buttons not being the bottommost element.

We could also use the info icon seen in the gamesetup, but that then won't help preventing the repetitive question in the lobby how to find the replay file. People are failing to RTFM, but mods shouldn't have to pay for that.

Sandarac accepted this revision.May 23 2017, 10:51 PM

This is was discussed again, and I believe that this would be good to have for the next release. Being able to copy the replay path is not as important as
actually making it clear for new-comers where replays are stored.

(Placing the path under the buttons does make it look awkward and out-of-place; the way it is positioned now is fine.)

This revision is now accepted and ready to land.May 23 2017, 10:51 PM
elexis updated this revision to Diff 2166.May 24 2017, 2:28 PM

Add sprite support for replays, add a sprite that resembles the backdrop of the olist as proposed by Imarok.
Not sure if this thing actually compiles on windows.

This revision was automatically updated to reflect the committed changes.

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/1337/ for more details.